[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-i18n-doc
Subject: Re: Review Request 128914: Import filetypes kcm docbook from kde-runtime master to kde-cli-tools wit
From: Albert Astals Cid <aacid () kde ! org>
Date: 2016-10-16 21:16:25
Message-ID: 20161016211625.7699.86402 () mimi ! kde ! org
[Download RAW message or body]
--===============3116809976472569989==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128914/#review100053
-----------------------------------------------------------
Maybe plasma people would be more confortable if the "Todo next" changes where in a \
different review?
Is this something you can work on?
- Albert Astals Cid
On Sept. 15, 2016, 9:08 a.m., Burkhard Lück wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128914/
> -----------------------------------------------------------
>
> (Updated Sept. 15, 2016, 9:08 a.m.)
>
>
> Review request for Documentation, Localization and Translation (l10n) and Plasma.
>
>
> Repository: kde-cli-tools
>
>
> Description
> -------
>
> doc/kcontrol/filetypes/ splitted from kde-runtime master using \
> https://github.com/ajdruff/git-splits
> Not included in build so far, the docbook ismported as it was splitted
>
> To be done next:
> adapt CMakeLists.txt, change dtd to kf5,
> reapply one update done in plasma-desktop
> make co-installable, see https://git.reviewboard.kde.org/r/128912/
> remove this imported kcontrol docbook from plasma-desktop
> adapt scripty to these changes
>
>
> Diffs
> -----
>
> doc/kcontrol/filetypes/CMakeLists.txt PRE-CREATION
> doc/kcontrol/filetypes/index.docbook PRE-CREATION
>
> Diff: https://git.reviewboard.kde.org/r/128914/diff/
>
>
> Testing
> -------
>
> history looks good, see git-log-doc-kcontrol-kio-cli-tools.output, same log in \
> kde-runtime master
>
> File Attachments
> ----------------
>
> git-log-doc-kcontrol-kio-cli-tools.output
> https://git.reviewboard.kde.org/media/uploaded/files/2016/09/15/32f72127-aa97-4393-88e1-d830e35dbfe2__git-log-doc-kcontrol-kio-cli-tools.output
>
>
> Thanks,
>
> Burkhard Lück
>
>
--===============3116809976472569989==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/128914/">https://git.reviewboard.kde.org/r/128914/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Maybe \
plasma people would be more confortable if the "Todo next" changes where in a \
different review?</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">Is this something you can work \
on?</p></pre> <br />
<p>- Albert Astals Cid</p>
<br />
<p>On September 15th, 2016, 9:08 a.m. UTC, Burkhard Lück wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Documentation, Localization and Translation (l10n) and \
Plasma.</div> <div>By Burkhard Lück.</div>
<p style="color: grey;"><i>Updated Sept. 15, 2016, 9:08 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kde-cli-tools
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">doc/kcontrol/filetypes/ splitted from kde-runtime \
master using https://github.com/ajdruff/git-splits</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Not \
included in build so far, the docbook ismported as it was splitted</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">To be done next: adapt CMakeLists.txt, change dtd to kf5,
reapply one update done in plasma-desktop
make co-installable, see https://git.reviewboard.kde.org/r/128912/
remove this imported kcontrol docbook from plasma-desktop
adapt scripty to these changes</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">history looks good, see \
git-log-doc-kcontrol-kio-cli-tools.output, same log in kde-runtime master</p></pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>doc/kcontrol/filetypes/CMakeLists.txt <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>doc/kcontrol/filetypes/index.docbook <span style="color: \
grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/128914/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/09/15/32f72127 \
-aa97-4393-88e1-d830e35dbfe2__git-log-doc-kcontrol-kio-cli-tools.output">git-log-doc-kcontrol-kio-cli-tools.output</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============3116809976472569989==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic