[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-i18n-doc
Subject: Re: Review Request 7181: Fix by-po stats pages on i18n.kde.org to link entries to checkout of po fil
From: Albert Astals Cid <aacid () kde ! org>
Date: 2016-09-05 22:26:04
Message-ID: 20160905222604.19600.32782 () mimi ! kde ! org
[Download RAW message or body]
--===============6585976246450718093==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://svn.reviewboard.kde.org/r/7181/#review11262
-----------------------------------------------------------
Ship it!
Ship It!
- Albert Astals Cid
On Sept. 1, 2016, 12:55 p.m., Friedrich W. H. Kossebau wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://svn.reviewboard.kde.org/r/7181/
> -----------------------------------------------------------
>
> (Updated Sept. 1, 2016, 12:55 p.m.)
>
>
> Review request for Localization and Translation (l10n), Burkhard Lück and Albert \
> Astals Cid.
>
> Repository: kde
>
>
> Description
> -------
>
> When browsing the stats pages by po file \
> (http://i18n.kde.org/stats/gui/trunk-kf5/po/) and then selecting a po file (e.g. \
> http://i18n.kde.org/stats/gui/trunk-kf5/po/krita.po/), the links added to the team \
> names point to a bogus url (base url + teamname added).
> Instead of that bogus link, it would be nice if those links were pointing to the \
> checkout of the respective po file, as a few times I already ended up on those \
> by-po pages when I wanted to get a certain po files in a few languages, for testing \
> purposes (just last night for some krita.po ones).
> Attached untested patch hopes to turn the broken link into something useful.
>
>
> Diffs
> -----
>
> trunk/www/areas/l10n/stats/level2bypo.php 1468497
> trunk/www/areas/l10n/stats/line-functions.inc.php 1468497
>
> Diff: https://svn.reviewboard.kde.org/r/7181/diff/
>
>
> Testing
> -------
>
> None done, written blindly.
>
>
> Thanks,
>
> Friedrich W. H. Kossebau
>
>
--===============6585976246450718093==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://svn.reviewboard.kde.org/r/7181/">https://svn.reviewboard.kde.org/r/7181/</a>
</td>
</tr>
</table>
<br />
<p>
Ship it!
</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre> <br />
<p>- Albert Astals Cid</p>
<br />
<p>On September 1st, 2016, 12:55 p.m. UTC, Friedrich W. H. Kossebau wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Localization and Translation (l10n), Burkhard Lück and \
Albert Astals Cid.</div> <div>By Friedrich W. H. Kossebau.</div>
<p style="color: grey;"><i>Updated Sept. 1, 2016, 12:55 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kde
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">When browsing the stats pages by po file \
(http://i18n.kde.org/stats/gui/trunk-kf5/po/) and then selecting a po file (e.g. \
http://i18n.kde.org/stats/gui/trunk-kf5/po/krita.po/), the links added to the team \
names point to a bogus url (base url + teamname added).</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Instead of that bogus link, it would be nice if those links were pointing \
to the checkout of the respective po file, as a few times I already ended up on those \
by-po pages when I wanted to get a certain po files in a few languages, for testing \
purposes (just last night for some krita.po ones).</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Attached untested patch hopes to turn the broken link into something \
useful.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">None done, written blindly.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>trunk/www/areas/l10n/stats/level2bypo.php <span style="color: \
grey">(1468497)</span></li>
<li>trunk/www/areas/l10n/stats/line-functions.inc.php <span style="color: \
grey">(1468497)</span></li>
</ul>
<p><a href="https://svn.reviewboard.kde.org/r/7181/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============6585976246450718093==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic