[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-i18n-doc
Subject: Re: Review Request 128638: Move kwallet-query docbook to correct subdir
From: Aleix Pol Gonzalez <aleixpol () kde ! org>
Date: 2016-08-09 23:32:07
Message-ID: 20160809233207.9365.13779 () mimi ! kde ! org
[Download RAW message or body]
--===============0072172827265645302==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128638/#review98251
-----------------------------------------------------------
Ship it!
It's useful when copying stuff around to use `git diff --find-copies-harder` so moves \
are actual moves rather than destruction + creation.
- Aleix Pol Gonzalez
On Aug. 9, 2016, 9:14 p.m., Burkhard Lück wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128638/
> -----------------------------------------------------------
>
> (Updated Aug. 9, 2016, 9:14 p.m.)
>
>
> Review request for KDE Frameworks, Localization and Translation (l10n) and David \
> Faure.
>
> Repository: kwallet
>
>
> Description
> -------
>
> move docbook into subdit with matching name in l10n subdir + adapt \
> docs/CMakeLists.txt
> Rationale:
>
> The Translated docbooks in this frameworks are missing in the tarball, see \
> https://todo.kde.org/?controller=task&action=show&task_id=520
> To find out which subdir of docs/frameworks subdir it should grab translated
> docs from, the frameworks release script uses the name of the subdir in the \
> sources.
> On the other hand the script autogen.sh in l10n-kf5/scripts generates the \
> CMakeLists.txt files with the correct install paths/names for the language docbooks \
> using the dirnames in l10n/[lang]/documentation.
>
> Diffs
> -----
>
> docs/CMakeLists.txt c4ef9c7
> docs/kwallet-query/CMakeLists.txt PRE-CREATION
> docs/kwallet-query/man-kwallet-query.1.docbook PRE-CREATION
> docs/kwallet-query/using.adoc PRE-CREATION
> docs/man-kwallet-query.1.docbook eed6e43
> docs/using.adoc e2e01e4
>
> Diff: https://git.reviewboard.kde.org/r/128638/diff/
>
>
> Testing
> -------
>
> builds and installs the manpage to the same dir as before
>
>
> Thanks,
>
> Burkhard Lück
>
>
--===============0072172827265645302==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/128638/">https://git.reviewboard.kde.org/r/128638/</a>
</td>
</tr>
</table>
<br />
<p>
Ship it!
</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">It's \
useful when copying stuff around to use <code style="text-rendering: inherit;color: \
#4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">git diff \
--find-copies-harder</code> so moves are actual moves rather than destruction + \
creation.</p></pre> <br />
<p>- Aleix Pol Gonzalez</p>
<br />
<p>On August 9th, 2016, 9:14 p.m. CEST, Burkhard Lück wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Frameworks, Localization and Translation (l10n) and David \
Faure.</div> <div>By Burkhard Lück.</div>
<p style="color: grey;"><i>Updated Aug. 9, 2016, 9:14 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kwallet
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">move docbook into subdit with matching name in l10n \
subdir + adapt docs/CMakeLists.txt</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">Rationale:</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">The Translated docbooks in this frameworks are missing in the tarball, see \
https://todo.kde.org/?controller=task&action=show&task_id=520</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">To find out which subdir of docs/frameworks subdir it should grab \
translated docs from, the frameworks release script uses the name of the subdir in \
the sources.</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">On the other hand the script autogen.sh in \
l10n-kf5/scripts generates the CMakeLists.txt files with the correct install \
paths/names for the language docbooks using the dirnames in \
l10n/[lang]/documentation.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">builds and installs the manpage to the same dir as \
before</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>docs/CMakeLists.txt <span style="color: grey">(c4ef9c7)</span></li>
<li>docs/kwallet-query/CMakeLists.txt <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>docs/kwallet-query/man-kwallet-query.1.docbook <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>docs/kwallet-query/using.adoc <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>docs/man-kwallet-query.1.docbook <span style="color: grey">(eed6e43)</span></li>
<li>docs/using.adoc <span style="color: grey">(e2e01e4)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/128638/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============0072172827265645302==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic