[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-i18n-doc
Subject: Re: Review Request 126442: kcmshell5 kamera i18n missing TRANSLATION_DOMAIN
From: Leslie Zhai <xiangzhai83 () gmail ! com>
Date: 2016-07-22 1:28:30
Message-ID: 20160722012830.4909.44637 () mimi ! kde ! org
[Download RAW message or body]
--===============2431585795864311281==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
> On 七月 15, 2016, 10:41 p.m., Luigi Toscano wrote:
> > For i18n-related reviews, I suggest you to add the i18n group as well.
> >
> > I tested this and it seems to work, but as you are not the author, could you \
> > please provide the name and email of the author of the patch? Luckily git allows \
> > us to set the proper author for the patches.
>
> Leslie Zhai wrote:
> Hi Luigi,
>
> I have added l10n group for review ;-)
>
> The author of the patch is cjacker https://github.com/cjacker \
> jianzhong.huang@i-soft.com.cn
> Regards,
> Leslie Zhai
>
> Luigi Toscano wrote:
> I'm going to push this, but just to be sure (as the system rejects a single name), \
> is the full name cjacker huang?
> Luigi Toscano wrote:
> Or is it better JianZhong Huang (or the proper Huang JianZhong)?
>
> Leslie Zhai wrote:
> Hi Luigi,
>
> I git push it ;-)
>
> cjacker is pinoeer of KDE developer https://www.linux-apps.com/member/6403/
> also he reported bug and contributed patch \
> https://bugs.kde.org/show_bug.cgi?id=59082
> Even he has a lot of A.K.A, but we all prefer to call him - cjacker ;-)
>
> Regards,
> Leslie Zhai
>
> Luigi Toscano wrote:
> Yes, but you committed it with your user. You should have used the git option to \
> assign the authorship to cjacker (git commit --author="name <email>"; you can \
> change an existing commit with --amend). But our system needs two names in order to \
> push (which could be disputed, but still). I'm going to revert the change for now, \
> and ask again: what is the name that should be assigned as author of this patch \
> (that should go first to Applications/16.08)? I can take care of properly \
> committing it.
> Leslie Zhai wrote:
> cjacker <jianzhong.huang@i-soft.com.cn> he is my boss ;-P
>
> Luigi Toscano wrote:
> That's fine, but if you try to use "cjacker <jianzhong.huang@i-soft.com.cn>" as the \
> author for a commit, our git will reject it, as it needs "name surname <email>". I \
> understand that this assumption is not always true, but can we quickly solve it \
> here with the full name. That's what I'm asking :)
> Leslie Zhai wrote:
> Oh, I forgot to mention that he did NOT have KDE Developers' identity but could \
> report bug, so I git commit for him instead ;-)
> The same stories like:
> https://git.reviewboard.kde.org/r/128296/
> https://git.reviewboard.kde.org/r/126488/
> https://git.reviewboard.kde.org/r/126487/
> https://git.reviewboard.kde.org/r/126445/
> https://git.reviewboard.kde.org/r/126486/
> https://git.reviewboard.kde.org/r/126444/
>
> Luigi Toscano wrote:
> You can git commit for him, but you need to specify him as author when you commit! \
> Please re-read my message above: can you please provide a name for him which follow \
> the patterh "name surname <email>"? You can then specify that value with git commit \
> --author and then we will be fine. But please, please answer or we are not going \
> anywhere.
> Leslie Zhai wrote:
> I use git commit --author="cjacker Jianzhong Huang <jianzhong.huang@i-soft.com.cn>" \
> but the author is still me!? \
> https://quickgit.kde.org/?p=kamera.git&a=commit&h=82b6e76a5b6ca69cc14a445c9a976bb8e007eec1 \
> please help me to fix it, thanks a lot!
> Luigi Toscano wrote:
> If you notice that something is wrong with git, don't push!You can't change \
> something that was pushed. Undo your change locally and try again.
> Now I will revert the commit again and push with the proper authorship. Also, this \
> should be put into Applications/16.08 first (and then merged to master, I will take \
> care of it).
> About changing the author, please read:
> https://www.git-tower.com/learn/git/faq/change-author-name-email
>
> If you already committed locally and you want to change the authorshio, you can use \
> A git commit --amend --author "name <email>"
>
> If it is a new commit, just use
> git commit --author "name <email>"
Thanks for your help ;-)
- Leslie
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126442/#review97453
-----------------------------------------------------------
On 七月 18, 2016, 1:23 a.m., Leslie Zhai wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126442/
> -----------------------------------------------------------
>
> (Updated 七月 18, 2016, 1:23 a.m.)
>
>
> Review request for Localization and Translation (l10n), Marcus Meissner and Marcel \
> Wiesweg.
>
> Repository: kamera
>
>
> Description
> -------
>
> so cjacker just added
>
> ```
> add_definitions(-DTRANSLATION_DOMAIN=\"kcmkamera\")
> ```
>
> in the CMakeLists.txt
>
>
> Diffs
> -----
>
> kcontrol/CMakeLists.txt 480e9c1
>
> Diff: https://git.reviewboard.kde.org/r/126442/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Leslie Zhai
>
>
--===============2431585795864311281==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/126442/">https://git.reviewboard.kde.org/r/126442/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On 七月 15th, 2016, 10:41 p.m. UTC, <b>Luigi \
Toscano</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">For i18n-related reviews, I suggest you to add the \
i18n group as well.</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">I tested this and it seems to work, but \
as you are not the author, could you please provide the name and email of the author \
of the patch? Luckily git allows us to set the proper author for the \
patches.</p></pre> </blockquote>
<p>On 七月 16th, 2016, 6:19 a.m. UTC, <b>Leslie Zhai</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Hi \
Luigi,</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">I have added l10n group for review ;-)</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">The author of the patch is cjacker https://github.com/cjacker \
jianzhong.huang@i-soft.com.cn</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">Regards, Leslie \
Zhai</p></pre> </blockquote>
<p>On 七月 16th, 2016, 9:48 p.m. UTC, <b>Luigi Toscano</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I'm \
going to push this, but just to be sure (as the system rejects a single name), is the \
full name cjacker huang?</p></pre> </blockquote>
<p>On 七月 16th, 2016, 9:52 p.m. UTC, <b>Luigi Toscano</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Or is it better \
JianZhong Huang (or the proper Huang JianZhong)?</pre> </blockquote>
<p>On 七月 18th, 2016, 1:32 a.m. UTC, <b>Leslie Zhai</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Hi \
Luigi,</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">I git push it ;-)</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">cjacker is pinoeer of KDE developer https://www.linux-apps.com/member/6403/ \
also he reported bug and contributed patch \
https://bugs.kde.org/show_bug.cgi?id=59082</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">Even he has a lot of \
A.K.A, but we all prefer to call him - cjacker ;-)</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Regards, Leslie Zhai</p></pre>
</blockquote>
<p>On 七月 18th, 2016, 9:41 a.m. UTC, <b>Luigi Toscano</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Yes, \
but you committed it with your user. You should have used the git option to assign \
the authorship to cjacker (git commit --author="name <email>"; you can change \
an existing commit with --amend). But our system needs two names in order to push \
(which could be disputed, but still). I'm going to revert the change for now, and ask \
again: what is the name that should be assigned as author of this patch (that should \
go first to Applications/16.08)? I can take care of properly committing it.</p></pre> \
</blockquote>
<p>On 七月 19th, 2016, 1:14 a.m. UTC, <b>Leslie Zhai</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">cjacker <a \
href="mailto:jianzho \
;ng.huang@i-soft.com.cn" \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
normal;">jianzhong.hua&# \
110;g@i-soft.com.cn</a> \
he is my boss ;-P</p></pre> </blockquote>
<p>On 七月 19th, 2016, 5:08 p.m. UTC, <b>Luigi Toscano</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">That's fine, but if you try to use "cjacker <a \
href="mailto:jianzho \
;ng.huang@i-soft.com.cn" \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
normal;">jianzhong.hua&# \
110;g@i-soft.com.cn</a>" \
as the author for a commit, our git will reject it, as it needs "name surname \
<email>". I understand that this assumption is not always true, but can we \
quickly solve it here with the full name. That's what I'm asking :)</p></pr e>
</blockquote>
<p>On 七月 20th, 2016, 2:11 a.m. UTC, <b>Leslie Zhai</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Oh, I \
forgot to mention that he did NOT have KDE Developers' identity but could report bug, \
so I git commit for him instead ;-) </p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">The same stories like: \
https://git.reviewboard.kde.org/r/128296/ https://git.reviewboard.kde.org/r/126488/
https://git.reviewboard.kde.org/r/126487/
https://git.reviewboard.kde.org/r/126445/
https://git.reviewboard.kde.org/r/126486/
https://git.reviewboard.kde.org/r/126444/</p></pre>
</blockquote>
<p>On 七月 20th, 2016, 7:18 a.m. UTC, <b>Luigi Toscano</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">You \
can git commit for him, but you need to specify him as author when you commit! Please \
re-read my message above: can you please provide a name for him which follow the \
patterh "name surname <email>"? You can then specify that value with git commit \
--author and then we will be fine. But please, please answer or we are not going \
anywhere.</p></pre> </blockquote>
<p>On 七月 21st, 2016, 1:33 a.m. UTC, <b>Leslie Zhai</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I use \
git commit --author="cjacker Jianzhong Huang <a \
href="mailto:jianzho \
;ng.huang@i-soft.com.cn" \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
normal;">jianzhong.hua&# \
110;g@i-soft.com.cn</a>" \
but the author is still me!? \
https://quickgit.kde.org/?p=kamera.git&a=commit&h=82b6e76a5b6ca69cc14a445c9a976bb8e007eec1 \
please help me to fix it, thanks a lot!</p></pre> </blockquote>
<p>On 七月 21st, 2016, 7:58 p.m. UTC, <b>Luigi Toscano</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">If \
you notice that something is wrong with git, don't push!You can't change something \
that was pushed. Undo your change locally and try again.</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Now I \
will revert the commit again and push with the proper authorship. Also, this should \
be put into Applications/16.08 first (and then merged to master, I will take care of \
it). </p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">About changing the author, please read: \
https://www.git-tower.com/learn/git/faq/change-author-name-email</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">If you already committed locally and you want to change the authorshio, you \
can use A git commit --amend --author "name <email>"</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">If it is a new commit, just use git commit --author \
"name <email>"</p></pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Thanks for your help ;-)</p></pre> <br />
<p>- Leslie</p>
<br />
<p>On 七月 18th, 2016, 1:23 a.m. UTC, Leslie Zhai wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Localization and Translation (l10n), Marcus Meissner and \
Marcel Wiesweg.</div> <div>By Leslie Zhai.</div>
<p style="color: grey;"><i>Updated 七月 18, 2016, 1:23 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kamera
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">so cjacker just added </p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;"><div \
class="codehilite" style="background: #f8f8f8"><pre style="line-height: \
125%">add_definitions(-DTRANSLATION_DOMAIN=\"kcmkamera\") </pre></div>
</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">in the CMakeLists.txt</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kcontrol/CMakeLists.txt <span style="color: grey">(480e9c1)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/126442/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============2431585795864311281==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic