[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-i18n-doc
Subject:    Re: Review Request 126442: kcmshell5 kamera i18n missing TRANSLATION_DOMAIN
From:       Leslie Zhai <xiangzhai83 () gmail ! com>
Date:       2016-07-18 1:23:32
Message-ID: 20160718012332.20341.25376 () mimi ! kde ! org
[Download RAW message or body]

--===============0338260479113846024==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126442/
-----------------------------------------------------------

(Updated July 18, 2016, 1:23 a.m.)


Status
------

This change has been marked as submitted.


Review request for Localization and Translation (l10n), Marcus Meissner and Marcel \
Wiesweg.


Changes
-------

Submitted with commit 8587a011f2d7525596149fc53f2957587ab84e5b by Leslie Zhai to \
branch master.


Repository: kamera


Description
-------

so cjacker just added 

```
add_definitions(-DTRANSLATION_DOMAIN=\"kcmkamera\")
```

in the CMakeLists.txt


Diffs
-----

  kcontrol/CMakeLists.txt 480e9c1 

Diff: https://git.reviewboard.kde.org/r/126442/diff/


Testing
-------


Thanks,

Leslie Zhai


--===============0338260479113846024==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit




<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/126442/">https://git.reviewboard.kde.org/r/126442/</a>
  </td>
    </tr>
   </table>
   <br />



<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>
   <h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1>  </td>
 </tr>
</table>
<br />


<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Localization and Translation (l10n), Marcus Meissner and \
Marcel Wiesweg.</div> <div>By Leslie Zhai.</div>


<p style="color: grey;"><i>Updated July 18, 2016, 1:23 a.m.</i></p>



<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Submitted with commit 8587a011f2d7525596149fc53f2957587ab84e5b by Leslie \
Zhai to branch master.</pre>  </td>
 </tr>
</table>







<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kamera
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">so cjacker just added </p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;"><div \
class="codehilite" style="background: #f8f8f8"><pre style="line-height: \
125%">add_definitions(-DTRANSLATION_DOMAIN=\&quot;kcmkamera\&quot;) </pre></div>
</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">in the CMakeLists.txt</p></pre>  </td>
 </tr>
</table>



<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kcontrol/CMakeLists.txt <span style="color: grey">(480e9c1)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/126442/diff/" style="margin-left: \
3em;">View Diff</a></p>






  </td>
 </tr>
</table>



  </div>
 </body>
</html>


--===============0338260479113846024==--


[prev in list] [next in list] [prev in thread] [next in thread]

Configure | About | News | Add a list | Sponsored by KoreLogic