From kde-i18n-doc Mon May 16 22:00:59 2016 From: Albert Astals Cid Date: Mon, 16 May 2016 22:00:59 +0000 To: kde-i18n-doc Subject: Re: Review Request 7161: Revert all changed lang docbooks, not only index.docbook Message-Id: <20160516220059.8498.82615 () mimi ! kde ! org> X-MARC-Message: https://marc.info/?l=kde-i18n-doc&m=146343608020574 --===============4617319314356617774== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://svn.reviewboard.kde.org/r/7161/#review11221 ----------------------------------------------------------- Ship it! Ship It! - Albert Astals Cid On May 15, 2016, 11:26 a.m., Burkhard Lück wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://svn.reviewboard.kde.org/r/7161/ > ----------------------------------------------------------- > > (Updated May 15, 2016, 11:26 a.m.) > > > Review request for Localization and Translation (l10n). > > > Repository: kde > > > Description > ------- > > If checkXML5 fails for a new generated lang docbook, as of now only the changed index.dobook is reverted. > > This is not sufficient for documentation whith more than one docbook. > In this case all changed lang docbooks have to be reverted. > > This patch should be applied to all four branches processed by Scripty. > > > Diffs > ----- > > trunk/l10n-kf5/scripts/update_xml 1460196 > > Diff: https://svn.reviewboard.kde.org/r/7161/diff/ > > > Testing > ------- > > Test case: > > Use update_xml without patch to generate the german docbbooks in application, only index.docbbok is reverted and lang de does not build anymore > > With patch all changed german docbooks are reverted and lang de still builds > > > Thanks, > > Burkhard Lück > > --===============4617319314356617774== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 8bit

This is an automatically generated e-mail. To reply, visit: https://svn.reviewboard.kde.org/r/7161/

Ship it!

Ship It!

- Albert Astals Cid

On May 15th, 2016, 11:26 a.m. UTC, Burkhard Lück wrote:

Review request for Localization and Translation (l10n).

By Burkhard Lück.

Updated May 15, 2016, 11:26 a.m.

Repository: kde

Description

If checkXML5 fails for a new generated lang docbook, as of now only the changed index.dobook is reverted.

This is not sufficient for documentation whith more than one docbook. In this case all changed lang docbooks have to be reverted.

This patch should be applied to all four branches processed by Scripty.

Testing

Test case:

Use update_xml without patch to generate the german docbbooks in application, only index.docbbok is reverted and lang de does not build anymore

With patch all changed german docbooks are reverted and lang de still builds

Diffs

trunk/l10n-kf5/scripts/update_xml (1460196)

View Diff

--===============4617319314356617774==--