[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-i18n-doc
Subject:    Review Request 7161: Revert all changed lang docbooks, not only index.docbook
From:       Burkhard_Lück <lueck () hube-lueck ! de>
Date:       2016-05-15 11:26:20
Message-ID: 20160515112620.8498.39361 () mimi ! kde ! org
[Download RAW message or body]

--===============2406925563158240546==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://svn.reviewboard.kde.org/r/7161/
-----------------------------------------------------------

Review request for Localization and Translation (l10n).


Repository: kde


Description
-------

If checkXML5 fails for a new generated lang docbook, as of now only the changed \
index.dobook is reverted.

This is not sufficient for documentation whith more than one docbook.
In this case all changed lang docbooks have to be reverted.

This patch should be applied to all four branches processed by Scripty.


Diffs
-----

  trunk/l10n-kf5/scripts/update_xml 1460196 

Diff: https://svn.reviewboard.kde.org/r/7161/diff/


Testing
-------

Test case:

Use update_xml without patch to generate the german docbbooks in application, only \
index.docbbok is reverted and lang de does not build anymore

With patch all changed german docbooks are reverted and lang de still builds


Thanks,

Burkhard Lück


--===============2406925563158240546==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit




<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://svn.reviewboard.kde.org/r/7161/">https://svn.reviewboard.kde.org/r/7161/</a>
  </td>
    </tr>
   </table>
   <br />




<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Localization and Translation (l10n).</div>
<div>By Burkhard Lück.</div>










<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kde
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">If checkXML5 fails for a new generated lang docbook, \
as of now only the changed index.dobook is reverted.</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This \
is not sufficient for documentation whith more than one docbook. In this case all \
changed lang docbooks have to be reverted.</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">This patch should be \
applied to all four branches processed by Scripty.</p></pre>  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Test case:</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">Use update_xml without \
patch to generate the german docbbooks in application, only index.docbbok is reverted \
and lang de does not build anymore</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">With patch all changed \
german docbooks are reverted and lang de still builds</p></pre>  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>trunk/l10n-kf5/scripts/update_xml <span style="color: \
grey">(1460196)</span></li>

</ul>

<p><a href="https://svn.reviewboard.kde.org/r/7161/diff/" style="margin-left: \
3em;">View Diff</a></p>






  </td>
 </tr>
</table>



  </div>
 </body>
</html>


--===============2406925563158240546==--


[prev in list] [next in list] [prev in thread] [next in thread]

Configure | About | News | Add a list | Sponsored by KoreLogic