[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-i18n-doc
Subject: Re: Review Request 127904: Rename directory docs/preparetips to preparetips5
From: Burkhard_Lück <lueck () hube-lueck ! de>
Date: 2016-05-14 22:06:52
Message-ID: 20160514220652.8534.63370 () mimi ! kde ! org
[Download RAW message or body]
--===============5249802538318094909==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127904/
-----------------------------------------------------------
(Updated May 14, 2016, 10:06 p.m.)
Status
------
This change has been marked as submitted.
Review request for KDE Frameworks, Localization and Translation (l10n) and David \
Faure.
Changes
-------
Submitted with commit 2b55dc1cfbed5dbf08dfa534517db9c0dc26e54b by Burkhard Lück to \
branch master.
Repository: kconfigwidgets
Description
-------
rename directory + adapt docs/CMakeLists.txt
Rationale:
Translated docbooks in several frameworks are missing in the tarballs, see \
https://todo.kde.org/?controller=task&action=show&task_id=520
To find out which subdir of docs/frameworks subdir it should grab translated
docs from, the frameworks release script uses the name of the subdir in the sources.
On the other hand the script autogen.sh in l10n-kf5/scripts generates the \
CMakeLists.txt files with the correct install paths/names for the language docbooks \
using the dirnames in l10n/[lang]/documentation.
Now the folder in the sources has a different name than the install name in the \
CMakeLists.txt, in this case dirname "preparetips" != install name "preparetips5".
Therefore doc/preparetips in kconfigwidgets is pulled into \
l10n-kf5/scripts/documentation with the name preparetips5 using an entry in \
documentation_paths in l10n-kf5/scripts and then processed by scripty and used by \
translation teams.
As discussed with David renaming the dirs in the frameworks repos is the easiest \
solution and does not require ugly hacks either in frameworks release script or in \
autogen.sh.
Together with commiting this change I'll adapt Scripty.
Similar changes are required for other frameworks (kdelibs4support, kio, kjs, \
kjsembed, kross, kwallet, plasma-framework) as well.
Diffs
-----
docs/CMakeLists.txt 2c3bd71
docs/preparetips/CMakeLists.txt 9a16d45
docs/preparetips/man-preparetips5.1.docbook cb7eee4
docs/preparetips5/CMakeLists.txt PRE-CREATION
docs/preparetips5/man-preparetips5.1.docbook PRE-CREATION
Diff: https://git.reviewboard.kde.org/r/127904/diff/
Testing
-------
builds and installs the manpage to the same dir as before
Thanks,
Burkhard Lück
--===============5249802538318094909==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/127904/">https://git.reviewboard.kde.org/r/127904/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr>
<td>
<h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1> </td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Frameworks, Localization and Translation (l10n) and David \
Faure.</div> <div>By Burkhard Lück.</div>
<p style="color: grey;"><i>Updated May 14, 2016, 10:06 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Submitted with commit 2b55dc1cfbed5dbf08dfa534517db9c0dc26e54b by \
Burkhard Lück to branch master.</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kconfigwidgets
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">rename directory + adapt docs/CMakeLists.txt</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Rationale:</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">Translated docbooks in several \
frameworks are missing in the tarballs, see \
https://todo.kde.org/?controller=task&action=show&task_id=520</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">To find out which subdir of docs/frameworks subdir it should grab \
translated docs from, the frameworks release script uses the name of the subdir in \
the sources.</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">On the other hand the script autogen.sh in \
l10n-kf5/scripts generates the CMakeLists.txt files with the correct install \
paths/names for the language docbooks using the dirnames in \
l10n/[lang]/documentation.</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">Now the folder in the sources has a \
different name than the install name in the CMakeLists.txt, in this case dirname \
"preparetips" != install name "preparetips5".</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Therefore doc/preparetips in kconfigwidgets is pulled into \
l10n-kf5/scripts/documentation with the name preparetips5 using an entry in \
documentation_paths in l10n-kf5/scripts and then processed by scripty and used by \
translation teams.</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">As discussed with David renaming the \
dirs in the frameworks repos is the easiest solution and does not require ugly hacks \
either in frameworks release script or in autogen.sh.</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Together with commiting this change I'll adapt Scripty.</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Similar changes are required for other frameworks (kdelibs4support, kio, \
kjs, kjsembed, kross, kwallet, plasma-framework) as well.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">builds and installs the manpage to the same dir as \
before</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>docs/CMakeLists.txt <span style="color: grey">(2c3bd71)</span></li>
<li>docs/preparetips/CMakeLists.txt <span style="color: grey">(9a16d45)</span></li>
<li>docs/preparetips/man-preparetips5.1.docbook <span style="color: \
grey">(cb7eee4)</span></li>
<li>docs/preparetips5/CMakeLists.txt <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>docs/preparetips5/man-preparetips5.1.docbook <span style="color: \
grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/127904/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============5249802538318094909==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic