[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-i18n-doc
Subject:    Re: [krita] /: Add missing i18n calls
From:       Boudewijn Rempt <boud () valdyas ! org>
Date:       2016-05-06 8:24:25
Message-ID: alpine.LNX.2.00.1605061023420.29597 () calcifer ! valdyas ! org
[Download RAW message or body]

On Fri, 6 May 2016, Pino Toscano wrote:

> Hi,
> 
> thanks for the fixes -- I have one question, and few notes.
> 
> The question is: do you plan to release more krita versions from the
> calligra/2.9 branch? If so, then please backport the patch (with the
> fixes below) there too.

Thanks for the notes -- and no, there won't be another 2.9 release. We hope
to release 3.0 end of this month.

> 
> On Friday 06 May 2016 07:48:33 Boudewijn Rempt wrote:
> > diff --git a/plugins/dockers/historydocker/KisUndoView.cpp \
> > b/plugins/dockers/historydocker/KisUndoView.cpp index 1a37dd4..7ce2fb4 100644
> > --- a/plugins/dockers/historydocker/KisUndoView.cpp
> > +++ b/plugins/dockers/historydocker/KisUndoView.cpp
> > [..]
> > -        s1->setToolTip("The amount of time every stroke should be \napart from \
> > its previous stroke\nto be classified in one group"); +        \
> > s1->setToolTip(i18nc("@info:tooltip", "The amount of time every stroke should be \
> > \napart from its previous stroke\nto be classified in one group"));
> 
> \n is not needed, Qt should automatically wrap the text of long
> tooltips.
> 
> > diff --git a/plugins/extensions/gmic/kis_gmic_widget.cpp \
> > b/plugins/extensions/gmic/kis_gmic_widget.cpp index 6add8cd..4e9fec9 100644
> > --- a/plugins/extensions/gmic/kis_gmic_widget.cpp
> > +++ b/plugins/extensions/gmic/kis_gmic_widget.cpp
> > @@ -89,12 +89,10 @@ void KisGmicWidget::createMainLayout()
> > connect(m_filterTree->selectionModel(), SIGNAL(selectionChanged (const \
> > QItemSelection &, const QItemSelection &)), this, \
> > SLOT(slotSelectedFilterChanged(const QItemSelection &, const QItemSelection &))); \
> >                 
> > -    if (!m_updateUrl.isEmpty())
> > -    {
> > -        updateBtn->setToolTip("Fetching definitions from : " + m_updateUrl);
> > +    if (!m_updateUrl.isEmpty()) {
> > +        updateBtn->setToolTip(i18nc("@info:tooltip", "Fetching definitions from: \
> > " + m_updateUrl));
> 
> A string puzzle is not a good idea; please use something like:
> i18nc("@info:tooltip", "Fetching definitions from: %1", m_updateUrl)
> 
> > diff --git a/plugins/flake/pathshapes/spiral/SpiralShapeConfigWidget.cpp \
> > b/plugins/flake/pathshapes/spiral/SpiralShapeConfigWidget.cpp index \
> >                 66f25ea..ec5db98 100644
> > --- a/plugins/flake/pathshapes/spiral/SpiralShapeConfigWidget.cpp
> > +++ b/plugins/flake/pathshapes/spiral/SpiralShapeConfigWidget.cpp
> > @@ -33,8 +33,8 @@ SpiralShapeConfigWidget::SpiralShapeConfigWidget()
> > widget.fade->setMaximum(1.0);
> > 
> > widget.clockWise->clear();
> > -    widget.clockWise->addItem("ClockWise");
> > -    widget.clockWise->addItem("Anti-ClockWise");
> > +    widget.clockWise->addItem(i18n("ClockWise"));
> > +    widget.clockWise->addItem(i18n("Anti-ClockWise"));
> 
> These should be "Anticlockwise" and "Clockwise", i.e. without the dash
> and the uppercase W.
> 
> > diff --git a/plugins/tools/basictools/kis_tool_measure.cc \
> > b/plugins/tools/basictools/kis_tool_measure.cc index 30e3b42..4fd9401 100644
> > --- a/plugins/tools/basictools/kis_tool_measure.cc
> > +++ b/plugins/tools/basictools/kis_tool_measure.cc
> > @@ -66,7 +66,7 @@ \
> > KisToolMeasureOptionsWidget::KisToolMeasureOptionsWidget(QWidget* parent, double \
> > unitBox->setCurrentIndex(m_unit.indexInListForUi(KoUnit::ListAll)); 
> > optionLayout->addWidget(unitBox, 0, 2);
> > -    optionLayout->addWidget(new QLabel("deg", this), 1, 2);
> > +    optionLayout->addWidget(new QLabel(i18n("degree:"), this), 1, 2);
> 
> "Degree:"?
> 
> > diff --git a/plugins/tools/karbonplugins/filtereffects/CompositeEffectConfigWidget.cpp \
> > b/plugins/tools/karbonplugins/filtereffects/CompositeEffectConfigWidget.cpp index \
> >                 dbc241b..1d06225 100644
> > --- a/plugins/tools/karbonplugins/filtereffects/CompositeEffectConfigWidget.cpp
> > +++ b/plugins/tools/karbonplugins/filtereffects/CompositeEffectConfigWidget.cpp
> > @@ -37,12 +37,12 @@ \
> > CompositeEffectConfigWidget::CompositeEffectConfigWidget(QWidget *parent) \
> > g->addWidget(new QLabel(i18n("Operation"), this), 0, 0); 
> > m_operation = new KComboBox(this);
> > -    m_operation->addItem("Over");
> > -    m_operation->addItem("In");
> > -    m_operation->addItem("Out");
> > -    m_operation->addItem("Atop");
> > -    m_operation->addItem("Xor");
> > -    m_operation->addItem("Arithmetic");
> > +    m_operation->addItem(i18n("Over"));
> > +    m_operation->addItem(i18n("In"));
> > +    m_operation->addItem(i18n("Out"));
> > +    m_operation->addItem(i18n("Atop"));
> > +    m_operation->addItem(i18n("Xor"));
> > +    m_operation->addItem(i18n("Arithmetic"));
> 
> Can you please add context to these strings, mentioning what they
> represent?
> 
> Thanks,
> 

-- 
Boudewijn Rempt | http://www.krita.org, http://www.valdyas.org


[prev in list] [next in list] [prev in thread] [next in thread]