[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-i18n-doc
Subject: Re: Review Request 7160: Skip json files with a kpluginfield but no translationsfields silently
From: Alex Richardson <arichardson.kde () gmail ! com>
Date: 2016-04-19 11:26:12
Message-ID: 20160419112612.24323.5835 () mimi ! kde ! org
[Download RAW message or body]
--===============5506817215936594539==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://svn.reviewboard.kde.org/r/7160/#review11218
-----------------------------------------------------------
Ship it!
Ship It!
- Alex Richardson
On April 19, 2016, 2:45 a.m., Burkhard Lück wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://svn.reviewboard.kde.org/r/7160/
> -----------------------------------------------------------
>
> (Updated April 19, 2016, 2:45 a.m.)
>
>
> Review request for Localization and Translation (l10n) and Alex Richardson.
>
>
> Repository: kde
>
>
> Description
> -------
>
> We have json files with a kpluginfield but no translationsfields like
> playground/pim/kpeoplevcard/src/kpeoplevcard.json
> {
> "Encoding": "UTF-8",
> "KPlugin": {
> "EnabledByDefault": true,
> "Id": "VCardProvider",
> "License": "LGPL",
> "ServiceTypes": [
> "KPeople/DataSource"
> ],
> "Version": "0.1"
> }
> }
> Therefore we need to test if the kplugin keys are in translationfields
>
>
> Diffs
> -----
>
> trunk/l10n-kf5/scripts/filljsonfrompo.py 1457823
>
> Diff: https://svn.reviewboard.kde.org/r/7160/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Burkhard Lück
>
>
--===============5506817215936594539==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://svn.reviewboard.kde.org/r/7160/">https://svn.reviewboard.kde.org/r/7160/</a>
</td>
</tr>
</table>
<br />
<p>
Ship it!
</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre> <br />
<p>- Alex Richardson</p>
<br />
<p>On April 19th, 2016, 2:45 a.m. UTC, Burkhard Lück wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Localization and Translation (l10n) and Alex \
Richardson.</div> <div>By Burkhard Lück.</div>
<p style="color: grey;"><i>Updated April 19, 2016, 2:45 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kde
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">We have json files with a kpluginfield but no \
translationsfields like playground/pim/kpeoplevcard/src/kpeoplevcard.json
{
"Encoding": "UTF-8",
"KPlugin": {
"EnabledByDefault": true,
"Id": "VCardProvider",
"License": "LGPL",
"ServiceTypes": [
"KPeople/DataSource"
],
"Version": "0.1"
}
}
Therefore we need to test if the kplugin keys are in translationfields</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>trunk/l10n-kf5/scripts/filljsonfrompo.py <span style="color: \
grey">(1457823)</span></li>
</ul>
<p><a href="https://svn.reviewboard.kde.org/r/7160/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============5506817215936594539==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic