[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-i18n-doc
Subject: Re: Review Request 7157: Include JSON files processed by CMake and exclude /tests/ folder
From: Albert Astals Cid <aacid () kde ! org>
Date: 2016-03-22 23:08:08
Message-ID: 20160322230808.21626.87875 () mimi ! kde ! org
[Download RAW message or body]
--===============7391330455483836252==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://svn.reviewboard.kde.org/r/7157/#review11211
-----------------------------------------------------------
trunk/l10n-kf5/scripts/handle_json_files.sh (line 28)
<https://svn.reviewboard.kde.org/r/7157/#comment14254>
I don't think it's a good idea to have .in and .cmake, let's standarize in one, \
.cmake mostly since it's the one we support for .desktop (see findfiles)
- Albert Astals Cid
On March 22, 2016, 2:25 p.m., Alex Richardson wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://svn.reviewboard.kde.org/r/7157/
> -----------------------------------------------------------
>
> (Updated March 22, 2016, 2:25 p.m.)
>
>
> Review request for Localization and Translation (l10n) and Albert Astals Cid.
>
>
> Repository: kde
>
>
> Description
> -------
>
> Include JSON files processed by CMake and exclude /tests/ folder
>
>
> Diffs
> -----
>
> trunk/l10n-kf5/scripts/handle_json_files.sh 1455183
>
> Diff: https://svn.reviewboard.kde.org/r/7157/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alex Richardson
>
>
--===============7391330455483836252==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://svn.reviewboard.kde.org/r/7157/">https://svn.reviewboard.kde.org/r/7157/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://svn.reviewboard.kde.org/r/7157/diff/1/?file=48709#file48709line28" \
style="color: black; font-weight: bold; text-decoration: \
underline;">trunk/l10n-kf5/scripts/handle_json_files.sh</a> <span \
style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">28</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="nv">jsonfilelist</span><span class="o">=</span><span class="k">$(</span>find \
<span class="s2">"</span><span class="nv">$BASEDIR</span><span \
class="s2">/</span><span class="k">$(</span>get_path <span \
class="s2">"</span><span class="nv">$mod</span><span \
class="s2">"</span><span class="k">)</span><span class="s2">"</span> -name \
<span class="s2">"*.json"</span> <span class="p">|</span> grep -v <span \
class="s1">'/autotests/'</span><span class="k">)</span></pre></td> <th \
bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">28</font></th> <td bgcolor="#fdfebc" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="nv">jsonfilelist</span><span class="o">=</span><span class="k">$(</span>find \
<span class="s2">"</span><span class="nv">$BASEDIR</span><span \
class="s2">/</span><span class="k">$(</span>get_path <span \
class="s2">"</span><span class="nv">$mod</span><span \
class="s2">"</span><span class="k">)</span><span class="s2">"</span> -name \
<span class="s2">"*.json"</span> <span class="hl">-o -name </span><span \
class="s2"><span class="hl">"*.json.in"</span></span><span class="hl"> -o \
-name </span><span class="s2"><span \
class="hl">"*.json.cmake"</span></span><span class="hl"> </span><span \
class="p">|</span> grep -v <span class="s1">'/autotests/'</span><span \
class="hl"> </span><span class="p"><span class="hl">|</span></span><span class="hl"> \
grep -v </span><span class="s1"><span class="hl">'/tests/'</span></span><span \
class= "k">)</span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I \
don't think it's a good idea to have .in and .cmake, let's standarize in one, .cmake \
mostly since it's the one we support for .desktop (see findfiles)</p></pre> </div>
</div>
<br />
<p>- Albert Astals Cid</p>
<br />
<p>On March 22nd, 2016, 2:25 p.m. UTC, Alex Richardson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Localization and Translation (l10n) and Albert Astals \
Cid.</div> <div>By Alex Richardson.</div>
<p style="color: grey;"><i>Updated March 22, 2016, 2:25 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kde
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Include JSON files processed by CMake and exclude /tests/ folder</pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>trunk/l10n-kf5/scripts/handle_json_files.sh <span style="color: \
grey">(1455183)</span></li>
</ul>
<p><a href="https://svn.reviewboard.kde.org/r/7157/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============7391330455483836252==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic