[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-i18n-doc
Subject: Re: Review Request 127275: Ki18n: Fallback to QLocale::system uiLanguages in language initalisation
From: Andre Heinecke <aheinecke () intevation ! de>
Date: 2016-03-08 11:34:48
Message-ID: 20160308113448.6298.67435 () mimi ! kde ! org
[Download RAW message or body]
--===============8769287028463159645==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127275/
-----------------------------------------------------------
(Updated March 8, 2016, 3:34 a.m.)
Status
------
This change has been marked as submitted.
Review request for KDE Frameworks and Localization and Translation (l10n).
Changes
-------
Submitted with commit 26750a15fba059d3a703131e9cd400893aa596a6 by Andre Heinecke to \
branch master.
Repository: ki18n
Description
-------
The intention for this patch is to fix the inital Language selection for Windows \
where the environment variables used in Ki18n are not set. This is not a fix for a \
regression in Ki18n, afaik this never worked on Windows, we had some hacks in Gpg4win \
to write the language into kdeglobals during installation in kde4 times.
I don't think this needs to be ifdefed because it only appends so previous language \
selection is not affected.
Diffs
-----
src/klocalizedstring.cpp b24fe9b
Diff: https://git.reviewboard.kde.org/r/127275/diff/
Testing
-------
Tested on a german Windows system and got a "de" localized application.
Thanks,
Andre Heinecke
--===============8769287028463159645==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/127275/">https://git.reviewboard.kde.org/r/127275/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr>
<td>
<h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1> </td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Frameworks and Localization and Translation (l10n).</div>
<div>By Andre Heinecke.</div>
<p style="color: grey;"><i>Updated March 8, 2016, 3:34 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Submitted with commit 26750a15fba059d3a703131e9cd400893aa596a6 by Andre \
Heinecke to branch master.</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
ki18n
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">The intention for this patch is to fix the inital \
Language selection for Windows where the environment variables used in Ki18n are not \
set. This is not a fix for a regression in Ki18n, afaik this never worked on Windows, \
we had some hacks in Gpg4win to write the language into kdeglobals during \
installation in kde4 times.</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">I don't think this needs to be ifdefed \
because it only appends so previous language selection is not affected.</p></pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Tested on a german Windows system and got a "de" \
localized application.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/klocalizedstring.cpp <span style="color: grey">(b24fe9b)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/127275/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============8769287028463159645==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic