From kde-i18n-doc Fri Jan 29 16:58:01 2016 From: Ragnar Thomsen Date: Fri, 29 Jan 2016 16:58:01 +0000 To: kde-i18n-doc Subject: Re: Review Request 126838: Fix a plural issue with unit count string Message-Id: <20160129165801.17778.37316 () mimi ! kde ! org> X-MARC-Message: https://marc.info/?l=kde-i18n-doc&m=145408669827633 --===============6587985898153455608== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126838/#review91784 ----------------------------------------------------------- Ship it! Looks good to me. Please commit if you have tested it. Thanks. - Ragnar Thomsen On Jan. 25, 2016, 11:54 p.m., Safa Alfulaij wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126838/ > ----------------------------------------------------------- > > (Updated Jan. 25, 2016, 11:54 p.m.) > > > Review request for Localization and Translation (l10n) and Ragnar Thomsen. > > > Repository: systemd-kcm > > > Description > ------- > > There is a plural string marked for translation by i18n instead of i18np. > It is "Total: %1 units, %2 active, %3 displayed", each part should be a separate plural string to be correctly translated. This patch fixes this. > > > Diffs > ----- > > src/kcmsystemd.cpp d9d9be1 > > Diff: https://git.reviewboard.kde.org/r/126838/diff/ > > > Testing > ------- > > > Thanks, > > Safa Alfulaij > > --===============6587985898153455608== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 7bit

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126838/

Ship it!

Looks good to me. Please commit if you have tested it. Thanks.

- Ragnar Thomsen

On January 25th, 2016, 11:54 p.m. CET, Safa Alfulaij wrote:

Review request for Localization and Translation (l10n) and Ragnar Thomsen.

By Safa Alfulaij.

Updated Jan. 25, 2016, 11:54 p.m.

Repository: systemd-kcm

Description

There is a plural string marked for translation by i18n instead of i18np. It is "Total: %1 units, %2 active, %3 displayed", each part should be a separate plural string to be correctly translated. This patch fixes this.

Diffs

src/kcmsystemd.cpp (d9d9be1)

View Diff

--===============6587985898153455608==--