[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-i18n-doc
Subject: Re: Review Request 7154: Handle the KDE-KIO-Protocols key in JSON translations
From: "Albert Astals Cid" <aacid () kde ! org>
Date: 2016-01-06 0:28:18
Message-ID: 20160106002818.29377.8109 () mimi ! kde ! org
[Download RAW message or body]
--===============2738297291535796701==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://svn.reviewboard.kde.org/r/7154/#review11209
-----------------------------------------------------------
Ship it!
Honestly I don't have enough knowledge of python to review this, but i'm not sure \
someone else has the time/skills to do the review, you wrote part of that script \
already so I'd say give it one or two days more and if noone complains commit it and \
let's monitor if something bad happens.
- Albert Astals Cid
On gen. 4, 2016, 4:17 p.m., Alex Richardson wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://svn.reviewboard.kde.org/r/7154/
> -----------------------------------------------------------
>
> (Updated gen. 4, 2016, 4:17 p.m.)
>
>
> Review request for Localization and Translation (l10n).
>
>
> Repository: kde
>
>
> Description
> -------
>
> Handle the KDE-KIO-Protocols key in JSON translations
>
>
> Contains a bit of refactoring as well but it's kinda tricky to split up into \
> separate patches
>
> Diffs
> -----
>
> trunk/l10n-kf5/scripts/createjsoncontext.py 1448457
> trunk/l10n-kf5/scripts/filljsonfrompo.py 1448457
> trunk/l10n-kf5/scripts/jsontranslationcommon.py PRE-CREATION
>
> Diff: https://svn.reviewboard.kde.org/r/7154/diff/
>
>
> Testing
> -------
>
> Tested with the file from https://git.reviewboard.kde.org/r/125869/
> Still works with JSON files from kactivities
>
>
> Thanks,
>
> Alex Richardson
>
>
--===============2738297291535796701==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://svn.reviewboard.kde.org/r/7154/">https://svn.reviewboard.kde.org/r/7154/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Honestly I don't have enough knowledge of python to review this, but i'm \
not sure someone else has the time/skills to do the review, you wrote part of that \
script already so I'd say give it one or two days more and if noone complains commit \
it and let's monitor if something bad happens.</p></pre> <br />
<p>- Albert Astals Cid</p>
<br />
<p>On gener 4th, 2016, 4:17 p.m. UTC, Alex Richardson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Localization and Translation (l10n).</div>
<div>By Alex Richardson.</div>
<p style="color: grey;"><i>Updated gen. 4, 2016, 4:17 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kde
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Handle the KDE-KIO-Protocols key in JSON \
translations</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Contains a bit of refactoring as well but it's kinda \
tricky to split up into separate patches</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Tested with the file from \
https://git.reviewboard.kde.org/r/125869/ Still works with JSON files from \
kactivities</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>trunk/l10n-kf5/scripts/createjsoncontext.py <span style="color: \
grey">(1448457)</span></li>
<li>trunk/l10n-kf5/scripts/filljsonfrompo.py <span style="color: \
grey">(1448457)</span></li>
<li>trunk/l10n-kf5/scripts/jsontranslationcommon.py <span style="color: \
grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://svn.reviewboard.kde.org/r/7154/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============2738297291535796701==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic