[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 126187: [Kickoff] Extract i18n also from .js files
From:       "Albert Astals Cid" <aacid () kde ! org>
Date:       2015-11-27 18:48:16
Message-ID: 20151127184816.23104.29921 () mimi ! kde ! org
[Download RAW message or body]

--===============8877493632202350966==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit



> On nov. 27, 2015, 6:37 p.m., Marco Martin wrote:
> > Ship It!

As an addendum: This is not "New messages" it's "already existing but untranslatable \
messages"


- Albert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126187/#review88902
-----------------------------------------------------------


On nov. 27, 2015, 6:33 p.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126187/
> -----------------------------------------------------------
> 
> (Updated nov. 27, 2015, 6:33 p.m.)
> 
> 
> Review request for Localization and Translation (l10n) and Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
> The "Add to Favorites" and "Remove from Favorites" action come from the tools.js \
> file. 
> Should that go into 5.5? It would add new translations, sure, but they might be \
> fixed for a minor release, otherwise they'd stay untranslated for all of 5.5 
> 
> Diffs
> -----
> 
> applets/kickoff/Messages.sh 034133a 
> 
> Diff: https://git.reviewboard.kde.org/r/126187/diff/
> 
> 
> Testing
> -------
> 
> No.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
> 


--===============8877493632202350966==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit




<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/126187/">https://git.reviewboard.kde.org/r/126187/</a>
  </td>
    </tr>
   </table>
   <br />





<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <p style="margin-top: 0;">On novembre 27th, 2015, 6:37 p.m. UTC, <b>Marco \
Martin</b> wrote:</p>  <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">  <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Ship It!</pre>  </blockquote>







</blockquote>

<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">As an \
addendum: This is not "New messages" it's "already existing but untranslatable \
messages"</p></pre> <br />










<p>- Albert</p>


<br />
<p>On novembre 27th, 2015, 6:33 p.m. UTC, Kai Uwe Broulik wrote:</p>








<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Localization and Translation (l10n) and Plasma.</div>
<div>By Kai Uwe Broulik.</div>


<p style="color: grey;"><i>Updated nov. 27, 2015, 6:33 p.m.</i></p>









<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-desktop
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">The "Add to Favorites" and "Remove from Favorites" \
action come from the tools.js file.</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">Should that go into \
5.5? It would add new translations, sure, but they might be fixed for a minor \
release, otherwise they'd stay untranslated for all of 5.5</p></pre>  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">No.</p></pre>  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>applets/kickoff/Messages.sh <span style="color: grey">(034133a)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/126187/diff/" style="margin-left: \
3em;">View Diff</a></p>






  </td>
 </tr>
</table>







  </div>
 </body>
</html>


--===============8877493632202350966==--


[Attachment #3 (text/plain)]

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[prev in list] [next in list] [prev in thread] [next in thread] 

Configure | About | News | Add a list | Sponsored by KoreLogic