[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-i18n-doc
Subject: Re: Review Request 125682: Pre-fill translator information for KAboutApplicationDialog
From: "Michael Pyne" <mpyne () kde ! org>
Date: 2015-10-22 0:31:33
Message-ID: 20151022003133.14267.23528 () mimi ! kde ! org
[Download RAW message or body]
--===============6818669669213172545==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125682/
-----------------------------------------------------------
(Updated Oct. 22, 2015, 12:31 a.m.)
Status
------
This change has been marked as submitted.
Review request for KDE Frameworks, Localization and Translation (l10n) and Albert \
Astals Cid.
Changes
-------
Submitted with commit e4d10c796ae8a3a7ecc6e7a338d6126259fa2583 by Michael Pyne to \
branch master.
Bugs: 345320
https://bugs.kde.org/show_bug.cgi?id=345320
Repository: kxmlgui
Description
-------
KAboutData has a placeholder for information regarding who translated the running \
KDE-based application (KAboutData::translators()). However it relies on the \
application developer to call KAboutData::setTranslator() since KCoreAddons (a Tier 1 \
framework) cannot use KI18n directly. Instead the Qt translation infrastructure is \
used where translations are unavoidable, but that is not compatible with KF5's i18n. \
This (IIUC) gives different behavior than KDE4, where KAboutData could (and did!) \
directly pull the translated list of translators, so application authors didn't have \
to do anything special for their about dialog to have the list of translators.
For the majority of our applications we can make the ::setTranslator() call on the \
application developer's behalf, as recommended by Albert on kdeframeworks-devel, and \
by doing so from KMainWindow (a relatively central location for KF5-using \
applications) we can use KI18n and get the accurately-translated message. Feeding the \
already-translated information into KAboutData should work to form the list of \
translators for later use by KAboutApplicationDialog, or other accessors of that \
information.
This patch implements all that. I avoided using a global startup method as suggested \
by Albert (since the Qt docs suggest that this startup would happen *before* the GUI \
starts up, and I want to make sure KI18n is available); KMainWindow seems the next \
best option, and even non-KXmlGuiWindow users might use this. There are probably \
other good alternatives too (maybe even the platform plugin?).
Diffs
-----
src/kmainwindow.h 11dcfca
src/kmainwindow.cpp 7c86841
Diff: https://git.reviewboard.kde.org/r/125682/diff/
Testing
-------
Compiled, apps all still work.
I find it hard to test whether the translators actually show up or not though, as I \
do not use translated KF5 apps.
Thanks,
Michael Pyne
--===============6818669669213172545==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/125682/">https://git.reviewboard.kde.org/r/125682/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr>
<td>
<h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1> </td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Frameworks, Localization and Translation (l10n) and \
Albert Astals Cid.</div> <div>By Michael Pyne.</div>
<p style="color: grey;"><i>Updated Oct. 22, 2015, 12:31 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Submitted with commit e4d10c796ae8a3a7ecc6e7a338d6126259fa2583 by \
Michael Pyne to branch master.</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=345320">345320</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kxmlgui
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">KAboutData has a placeholder for information regarding \
who translated the running KDE-based application (KAboutData::translators()). However \
it relies on the application developer to call KAboutData::setTranslator() since \
KCoreAddons (a Tier 1 framework) cannot use KI18n directly. Instead the Qt \
translation infrastructure is used where translations are unavoidable, but that is \
not compatible with KF5's i18n. This (IIUC) gives different behavior than KDE4, where \
KAboutData could (and did!) directly pull the translated list of translators, so \
application authors didn't have to do anything special for their about dialog to have \
the list of translators.</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">For the majority of our applications we \
can make the ::setTranslator() call on the application developer's behalf, as \
recommended by Albert on kdeframeworks-devel, and by doing so from KMainWindow (a \
relatively central location for KF5-using applications) we can use KI18n and get the \
accurately-translated message. Feeding the already-translated information into \
KAboutData should work to form the list of translators for later use by \
KAboutApplicationDialog, or other accessors of that information.</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">This patch implements all that. I avoided using a global startup method as \
suggested by Albert (since the Qt docs suggest that this startup would happen <em \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
normal;">before</em> the GUI starts up, and I want to make sure KI18n is available); \
KMainWindow seems the next best option, and even non-KXmlGuiWindow users might use \
this. There are probably other good alternatives too (maybe even the platform \
plugin?).</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Compiled, apps all still work.</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I \
find it hard to test whether the translators actually show up or not though, as I do \
not use translated KF5 apps.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/kmainwindow.h <span style="color: grey">(11dcfca)</span></li>
<li>src/kmainwindow.cpp <span style="color: grey">(7c86841)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/125682/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============6818669669213172545==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic