[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-i18n-doc
Subject: Re: Review Request 125561: Sync FindGettext.cmake macros with upstream module from CMake
From: "Jeremy Whiting" <jpwhiting () kde ! org>
Date: 2015-10-09 21:37:39
Message-ID: 20151009213739.17685.83849 () mimi ! kde ! org
[Download RAW message or body]
--===============1116466696057398432==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
> On Oct. 9, 2015, 2:26 p.m., Albert Astals Cid wrote:
> > This doesn't look like "a bugfix" to me.
>
> Jeremy Whiting wrote:
> Oh, but it is. Without this or cmake_policy(SET CMP0002 OLD) (see \
> https://bugs.kde.org/show_bug.cgi?id=316308) applications that have their own \
> translations in the tarball (everything we release from extragear) fails to build \
> with a newer cmake. With this change in the kdelibs cmake modules it builds fine by \
> setting a different target for each po folder.
> Albert Astals Cid wrote:
> Ok, bad wording, it's probably a bugfix, but doesn't look like a minimal bugfix, i \
> mean it's rewriting the whole file, is there nothing better than that we can do?
Ah, that I don't know. As I said before, following all this cmake macro stuff is \
somehow over my head (or I'm not trying hard enough, dunno). Hrvoje, is there a \
simpler way to do what you're proposing here?
- Jeremy
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125561/#review86580
-----------------------------------------------------------
On Oct. 8, 2015, 11:50 a.m., Hrvoje Senjan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125561/
> -----------------------------------------------------------
>
> (Updated Oct. 8, 2015, 11:50 a.m.)
>
>
> Review request for Build System, kdelibs, Localization and Translation (l10n), \
> Albert Astals Cid, and Alexander Neundorf.
>
> Repository: kdelibs
>
>
> Description
> -------
>
> Otherwise some apps fail to build with kdelibs >= 4.14.11:
> ```
> CMake Error at /usr/share/kde4/apps/cmake/modules/FindGettext.cmake:232 \
> (ADD_CUSTOM_TARGET): add_custom_target cannot create target "pofiles" because \
> another target with the same name already exists. The existing target is a custom \
> target created in source directory
> "/home/hrvoje/rpmbuild/BUILD/skanlite-1.1/po/be". See documentation for
> policy CMP0002 for more details.
> Call Stack (most recent call first):
> po/zh_CN/CMakeLists.txt:2 (GETTEXT_PROCESS_PO_FILES)
> ```
>
>
> Diffs
> -----
>
> cmake/modules/FindGettext.cmake 91e88f7
>
> Diff: https://git.reviewboard.kde.org/r/125561/diff/
>
>
> Testing
> -------
>
> Skanlite now builds.
>
>
> Thanks,
>
> Hrvoje Senjan
>
>
--===============1116466696057398432==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/125561/">https://git.reviewboard.kde.org/r/125561/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On October 9th, 2015, 2:26 p.m. MDT, <b>Albert \
Astals Cid</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px \
solid #d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This doesn't look like "a bugfix" to me.</p></pre> \
</blockquote>
<p>On October 9th, 2015, 3 p.m. MDT, <b>Jeremy Whiting</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Oh, \
but it is. Without this or cmake_policy(SET CMP0002 OLD) (see \
https://bugs.kde.org/show_bug.cgi?id=316308) applications that have their own \
translations in the tarball (everything we release from extragear) fails to build \
with a newer cmake. With this change in the kdelibs cmake modules it builds fine by \
setting a different target for each po folder.</p></pre> </blockquote>
<p>On October 9th, 2015, 3:24 p.m. MDT, <b>Albert Astals Cid</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Ok, \
bad wording, it's probably a bugfix, but doesn't look like a minimal bugfix, i mean \
it's rewriting the whole file, is there nothing better than that we can do?</p></pre> \
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Ah, \
that I don't know. As I said before, following all this cmake macro stuff is somehow \
over my head (or I'm not trying hard enough, dunno). Hrvoje, is there a simpler way \
to do what you're proposing here?</p></pre> <br />
<p>- Jeremy</p>
<br />
<p>On October 8th, 2015, 11:50 a.m. MDT, Hrvoje Senjan wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Build System, kdelibs, Localization and Translation (l10n), \
Albert Astals Cid, and Alexander Neundorf.</div> <div>By Hrvoje Senjan.</div>
<p style="color: grey;"><i>Updated Oct. 8, 2015, 11:50 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdelibs
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Otherwise some apps fail to build with kdelibs >= \
4.14.11:</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;"><div class="codehilite" style="background: \
#f8f8f8"><pre style="line-height: 125%">CMake Error at \
/usr/share/kde4/apps/cmake/modules/FindGettext.cmake:232 (ADD_CUSTOM_TARGET): \
add_custom_target cannot create target "pofiles" because another target \
with the same name already exists. The existing target is a custom target created \
in source directory "/home/hrvoje/rpmbuild/BUILD/skanlite-1.1/po/be". See \
documentation for policy CMP0002 for more details.
Call Stack (most recent call first):
po/zh_CN/CMakeLists.txt:2 (GETTEXT_PROCESS_PO_FILES)
</pre></div>
</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Skanlite now builds.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>cmake/modules/FindGettext.cmake <span style="color: grey">(91e88f7)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/125561/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============1116466696057398432==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic