[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-i18n-doc
Subject: Re: Review Request 125540: Use more descriptive names and comments for VPN plugins
From: "Lamarque Souza" <lamarque () kde ! org>
Date: 2015-10-06 15:58:41
Message-ID: 20151006155841.17685.59904 () mimi ! kde ! org
[Download RAW message or body]
--===============5513669529613515942==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125540/#review86434
-----------------------------------------------------------
Ship it!
Ship It!
- Lamarque Souza
On Oct. 6, 2015, 12:38 p.m., Jan Grulich wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125540/
> -----------------------------------------------------------
>
> (Updated Oct. 6, 2015, 12:38 p.m.)
>
>
> Review request for Localization and Translation (l10n), Network Management and \
> Lamarque Souza.
>
> Repository: plasma-nm
>
>
> Description
> -------
>
> Currently we have for each VPN plugin just its simple name and as a comment we have \
> just "xxxx plugin" which is kinda useless so I took more descriptive names and \
> comments from NetworkManager. Better comments can be used in future also for \
> tooltips, but so far from what I tried it doesn't seem to work for QActions.
>
> Diffs
> -----
>
> vpn/l2tp/plasmanetworkmanagement_l2tpui.desktop fd5ee6f
> vpn/openconnect/plasmanetworkmanagement_openconnectui.desktop e5440df
> vpn/openswan/plasmanetworkmanagement_openswanui.desktop 64e73cc
> vpn/openvpn/plasmanetworkmanagement_openvpnui.desktop 36a3ef9
> vpn/pptp/plasmanetworkmanagement_pptpui.desktop e02d46c
> vpn/ssh/plasmanetworkmanagement_sshui.desktop f775a46
> vpn/sstp/plasmanetworkmanagement_sstpui.desktop 267d166
> vpn/strongswan/plasmanetworkmanagement_strongswanui.desktop a327c23
> vpn/vpnc/plasmanetworkmanagement_vpncui.desktop 41f4e77
>
> Diff: https://git.reviewboard.kde.org/r/125540/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jan Grulich
>
>
--===============5513669529613515942==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/125540/">https://git.reviewboard.kde.org/r/125540/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre> <br />
<p>- Lamarque Souza</p>
<br />
<p>On October 6th, 2015, 12:38 p.m. UTC, Jan Grulich wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Localization and Translation (l10n), Network Management and \
Lamarque Souza.</div> <div>By Jan Grulich.</div>
<p style="color: grey;"><i>Updated Oct. 6, 2015, 12:38 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-nm
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Currently we have for each VPN plugin just its simple \
name and as a comment we have just "xxxx plugin" which is kinda useless so I took \
more descriptive names and comments from NetworkManager. Better comments can be used \
in future also for tooltips, but so far from what I tried it doesn't seem to work for \
QActions.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>vpn/l2tp/plasmanetworkmanagement_l2tpui.desktop <span style="color: \
grey">(fd5ee6f)</span></li>
<li>vpn/openconnect/plasmanetworkmanagement_openconnectui.desktop <span \
style="color: grey">(e5440df)</span></li>
<li>vpn/openswan/plasmanetworkmanagement_openswanui.desktop <span style="color: \
grey">(64e73cc)</span></li>
<li>vpn/openvpn/plasmanetworkmanagement_openvpnui.desktop <span style="color: \
grey">(36a3ef9)</span></li>
<li>vpn/pptp/plasmanetworkmanagement_pptpui.desktop <span style="color: \
grey">(e02d46c)</span></li>
<li>vpn/ssh/plasmanetworkmanagement_sshui.desktop <span style="color: \
grey">(f775a46)</span></li>
<li>vpn/sstp/plasmanetworkmanagement_sstpui.desktop <span style="color: \
grey">(267d166)</span></li>
<li>vpn/strongswan/plasmanetworkmanagement_strongswanui.desktop <span style="color: \
grey">(a327c23)</span></li>
<li>vpn/vpnc/plasmanetworkmanagement_vpncui.desktop <span style="color: \
grey">(41f4e77)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/125540/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============5513669529613515942==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic