'Re: Review Request 125257: i18nize Indexer State in balooctl and baloomonitor plugin'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-i18n-doc
Subject:    Re: Review Request 125257: i18nize Indexer State in balooctl and baloomonitor plugin
From:       "Pinak Ahuja" <pinak.ahuja () gmail ! com>
Date:       2015-09-19 5:28:50
Message-ID: 20150919052850.2235.16343 () mimi ! kde ! org
[Download RAW message or body]

--===============1361010572397584009==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125257/
-----------------------------------------------------------

(Updated Sept. 19, 2015, 5:28 a.m.)


Status
------

This change has been marked as submitted.


Review request for Baloo, Localization and Translation (l10n) and Vishesh Handa.


Changes
-------

Submitted with commit da5fb6c71b717f6a9547bcce8219bd40dcd3c446 by Pinak Ahuja to \
branch master.


Repository: baloo


Description
-------

Delibrately left of baloo-monitor as it will not be the final public facing interface \
and will be removed soon. (once I fix this https://git.reviewboard.kde.org/r/124720/)


Diffs
-----

  src/file/indexerstate.h b2bc8f4 
  src/qml/experimental/CMakeLists.txt 335cc9e 
  src/qml/experimental/Messages.sh PRE-CREATION 
  src/tools/baloo-monitor/CMakeLists.txt cf9ac51 
  src/tools/balooctl/Messages.sh 87bd496 

Diff: https://git.reviewboard.kde.org/r/125257/diff/


Testing
-------

Not too sure how to test it? Also I hope C++ qml plugins will work properly with \
i18n?


Thanks,

Pinak Ahuja


--===============1361010572397584009==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit




<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/125257/">https://git.reviewboard.kde.org/r/125257/</a>
  </td>
    </tr>
   </table>
   <br />



<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>
   <h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1>  </td>
 </tr>
</table>
<br />


<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Baloo, Localization and Translation (l10n) and Vishesh \
Handa.</div> <div>By Pinak Ahuja.</div>


<p style="color: grey;"><i>Updated Sept. 19, 2015, 5:28 a.m.</i></p>



<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Submitted with commit da5fb6c71b717f6a9547bcce8219bd40dcd3c446 by Pinak \
Ahuja to branch master.</pre>  </td>
 </tr>
</table>







<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
baloo
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Delibrately left of baloo-monitor as it will not be \
the final public facing interface and will be removed soon. (once I fix this \
https://git.reviewboard.kde.org/r/124720/)</p></pre>  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Not too sure how to test it? Also I hope C++ qml \
plugins will work properly with i18n?</p></pre>  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/file/indexerstate.h <span style="color: grey">(b2bc8f4)</span></li>

 <li>src/qml/experimental/CMakeLists.txt <span style="color: \
grey">(335cc9e)</span></li>

 <li>src/qml/experimental/Messages.sh <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>src/tools/baloo-monitor/CMakeLists.txt <span style="color: \
grey">(cf9ac51)</span></li>

 <li>src/tools/balooctl/Messages.sh <span style="color: grey">(87bd496)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/125257/diff/" style="margin-left: \
3em;">View Diff</a></p>






  </td>
 </tr>
</table>



  </div>
 </body>
</html>


--===============1361010572397584009==--


[prev in list] [next in list] [prev in thread] [next in thread]
Configure | About | News | Add a list | Sponsored by KoreLogic