--===============0707653130408572428== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122680/ ----------------------------------------------------------- (Updated May 6, 2015, 1:19 p.m.) Status ------ This change has been marked as submitted. Review request for KDE Frameworks, Localization and Translation (l10n), Albert Astals Cid, Martin Gräßlin, and Martin Klapetek. Changes ------- Submitted with commit 4928539a48edd4729174f9c8aa906cf63fbe1b45 by Martin Klapetek on behalf of Jerome Leclanche to branch master. Repository: kglobalaccel Description ------- Remove the runtime's KAboutData The about data was unexposed, but created a dependency on KCoreAddons (for KAboutData) and in turn on KI18n for the translations of the aboutData. This removes both dependencies as well as the string extraction scripts. -- Author notes: This is a RFC. We don't use kglobalaccel in LXQt but we would like to, however it currently has too many dependencies. See https://github.com/lxde/lxqt/issues/507 for related discussion. I'm unsure myself if the about data is actually exposed somewhere I completely missed, but it doesn't look that way. Diffs ----- CMakeLists.txt 68ad795 src/runtime/CMakeLists.txt e639fa5 src/runtime/globalshortcutsregistry.cpp 3e4d720 src/runtime/kglobalacceld.cpp 4e7cb9d src/runtime/main.cpp fdf4d62 Diff: https://git.reviewboard.kde.org/r/122680/diff/ Testing ------- Compiles and runs. No further testing done. Thanks, Jerome Leclanche --===============0707653130408572428== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 8bit
This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122680/

This change has been marked as submitted.

Review request for KDE Frameworks, Localization and Translation (l10n), Albert Astals Cid, Martin Gräßlin, and Martin Klapetek.
By Jerome Leclanche.

Updated May 6, 2015, 1:19 p.m.

Changes

Submitted with commit 4928539a48edd4729174f9c8aa906cf63fbe1b45 by Martin Klapetek on behalf of Jerome Leclanche to branch master.
Repository: kglobalaccel

Description 

Remove the runtime's KAboutData
    
The about data was unexposed, but created a dependency on KCoreAddons (for
KAboutData) and in turn on KI18n for the translations of the aboutData.
    
This removes both dependencies as well as the string extraction scripts.

--

Author notes: This is a RFC. We don't use kglobalaccel in LXQt but we would
like to, however it currently has too many dependencies. See
https://github.com/lxde/lxqt/issues/507 for related discussion.
I'm unsure myself if the about data is actually exposed somewhere I completely
missed, but it doesn't look that way.

Testing 

Compiles and runs. No further testing done.

Diffs

  • CMakeLists.txt (68ad795)
  • src/runtime/CMakeLists.txt (e639fa5)
  • src/runtime/globalshortcutsregistry.cpp (3e4d720)
  • src/runtime/kglobalacceld.cpp (4e7cb9d)
  • src/runtime/main.cpp (fdf4d62)

View Diff
--===============0707653130408572428==--