[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-i18n-doc
Subject:    Re: Review Request 123278: Enable translation scripting for date groups
From:       "Lasse Liehu" <lasse.liehu () gmail ! com>
Date:       2015-04-23 14:42:17
Message-ID: 20150423144217.5446.21610 () mimi ! kde ! org
[Download RAW message or body]

--===============7612278773833046506==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123278/
-----------------------------------------------------------

(Updated April 23, 2015, 2:42 p.m.)


Status
------

This change has been marked as submitted.


Review request for Dolphin and Localization and Translation (l10n).


Changes
-------

Submitted with commit 82bf562c34204d585df67594feab844cf9b599a1 by Lasse Liehu to \
branch master.


Repository: dolphin


Description
-------

This allows to work around limitations in Qt's date formatting.

Examples:

* Uppercasing the first character in a string because it's a title: Weekday and month \
                names returned by QDateTime::toString are usually lowercase.
* Correcting the noun case of a month name from "of [month]" to "in [month]" in \
Finnish: "of [month]" is correct when talking about a specific day, but wrong when \
talking about a specific month.


Diffs
-----

  src/kitemviews/kfileitemmodel.cpp eac3ddf 

Diff: https://git.reviewboard.kde.org/r/123278/diff/


Testing
-------

Checked that grouping by date still worked.


Thanks,

Lasse Liehu


--===============7612278773833046506==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit




<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/123278/">https://git.reviewboard.kde.org/r/123278/</a>
  </td>
    </tr>
   </table>
   <br />



<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>
   <h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1>  </td>
 </tr>
</table>
<br />


<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Dolphin and Localization and Translation (l10n).</div>
<div>By Lasse Liehu.</div>


<p style="color: grey;"><i>Updated April 23, 2015, 2:42 p.m.</i></p>



<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Submitted with commit 82bf562c34204d585df67594feab844cf9b599a1 by Lasse \
Liehu to branch master.</pre>  </td>
 </tr>
</table>







<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
dolphin
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This allows to work around limitations in Qt's date \
formatting.</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Examples:</p> <ul style="padding: 0;text-rendering: \
inherit;margin: 0 0 0 1em;line-height: inherit;white-space: normal;"> <li \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
normal;">Uppercasing the first character in a string because it's a title: Weekday \
and month names returned by QDateTime::toString are usually lowercase.</li> <li \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
normal;">Correcting the noun case of a month name from "of [month]" to "in [month]" \
in Finnish: "of [month]" is correct when talking about a specific day, but wrong when \
talking about a specific month.</li> </ul></pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Checked that grouping by date still worked.</p></pre>  \
</td>  </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/kitemviews/kfileitemmodel.cpp <span style="color: \
grey">(eac3ddf)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/123278/diff/" style="margin-left: \
3em;">View Diff</a></p>






  </td>
 </tr>
</table>



  </div>
 </body>
</html>


--===============7612278773833046506==--


[prev in list] [next in list] [prev in thread] [next in thread]

Configure | About | News | Add a list | Sponsored by KoreLogic