[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-i18n-doc
Subject: Re: Review Request 122680: kglobalaccel: Remove the runtime's KAboutData
From: "Albert Astals Cid" <aacid () kde ! org>
Date: 2015-03-02 19:01:08
Message-ID: 20150302190108.6755.74475 () probe ! kde ! org
[Download RAW message or body]
--===============0278066915786504254==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
> On mar. 2, 2015, 8:06 a.m., Martin Gräßlin wrote:
> > Ship It!
>
> Luigi Toscano wrote:
> Please fix the extracted pot so that it is called <file>_qt.pot.
>
> (personally speaking, I would strongly suggest lxde to use ki18n, but that's another \
> discussion)
> Luigi Toscano wrote:
> Sorry, there is also another change about the script used, check other tier1 frameworks
>
> Jerome Leclanche wrote:
> I don't understand what you're asking of me - in the last diff, I'm not touching the pot file \
> at all.
> Luigi Toscano wrote:
> Sorry again, it' s a bit.more complicated as there is already such _qt.pot file (the main \
> one). So probably it should be extended to extract also runtime translations and the \
> appropriate changes to translations domain applied here. Please cc i18n, I can't do a \
> complete check now.
> Luigi Toscano wrote:
> wrt why I'm asking: the Messages.sh, maybe the top-level one and few cmake calls to be \
> changed to have translations working. Plase add i18n group.
> Hrvoje Senjan wrote:
> i'd like to mention that translations for the daemon aren't working anyway with 5.7.0 tar, as \
> they aren't wrapped with ki18n macro, but with ECMPoQmTools
> Albert Astals Cid wrote:
> @Hrvoje, the daemon is using i18n just fine in 5.7.0, ecmpoqmtools is for the library which \
> uses .po.
> @Jerome, yes this change is incomplete, you either need to remove the Messages.sh in the \
> daemon and add the ecm loading of the existing kglobalaccel5_qt qm to the daemon or create \
> two different catalogs, i'd say having just one probably makes sense. You won't need \
> -DTRANSLATION_DOMAIN anymore since that's for ki18n
> Hrvoje Senjan wrote:
> afaics, ki18n only knowns about mo files, while all translations in kglobalaccel 5.7 are \
> installed as qm files.. it is also possible i missunderstood something ;-)
You're right, the cmake code is wrong and is installing kglobalaccel5.po wrongly as \
kglobalaccel5.qm I guess noone expected .qm and non .qm files to coexist in a single tarball.
- Albert
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122680/#review76863
-----------------------------------------------------------
On mar. 2, 2015, 9 a.m., Jerome Leclanche wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122680/
> -----------------------------------------------------------
>
> (Updated mar. 2, 2015, 9 a.m.)
>
>
> Review request for KDE Frameworks, Localization and Translation (l10n), Martin Gräßlin, and \
> Martin Klapetek.
>
> Repository: kglobalaccel
>
>
> Description
> -------
>
> Remove the runtime's KAboutData
>
> The about data was unexposed, but created a dependency on KCoreAddons (for
> KAboutData) and in turn on KI18n for the translations of the aboutData.
>
> This removes both dependencies as well as the string extraction scripts.
>
> --
>
> Author notes: This is a RFC. We don't use kglobalaccel in LXQt but we would
> like to, however it currently has too many dependencies. See
> https://github.com/lxde/lxqt/issues/507 for related discussion.
> I'm unsure myself if the about data is actually exposed somewhere I completely
> missed, but it doesn't look that way.
>
>
> Diffs
> -----
>
> CMakeLists.txt 68ad795
> src/runtime/CMakeLists.txt e639fa5
> src/runtime/globalshortcutsregistry.cpp 3e4d720
> src/runtime/kglobalacceld.cpp 4e7cb9d
> src/runtime/main.cpp fdf4d62
>
> Diff: https://git.reviewboard.kde.org/r/122680/diff/
>
>
> Testing
> -------
>
> Compiles and runs. No further testing done.
>
>
> Thanks,
>
> Jerome Leclanche
>
>
--===============0278066915786504254==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/122680/">https://git.reviewboard.kde.org/r/122680/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On març 2nd, 2015, 8:06 a.m. UTC, <b>Martin Gräßlin</b> \
wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; \
white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre> </blockquote>
<p>On març 2nd, 2015, 8:39 a.m. UTC, <b>Luigi Toscano</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; \
white-space: -o-pre-wrap; word-wrap: break-word;">Please fix the extracted pot so that it is \
called <file>_qt.pot.
(personally speaking, I would strongly suggest lxde to use ki18n, but that's another \
discussion)</pre> </blockquote>
<p>On març 2nd, 2015, 8:44 a.m. UTC, <b>Luigi Toscano</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; \
white-space: -o-pre-wrap; word-wrap: break-word;">Sorry, there is also another change about the \
script used, check other tier1 frameworks</pre> </blockquote>
<p>On març 2nd, 2015, 8:51 a.m. UTC, <b>Jerome Leclanche</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; \
white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">I don't understand what you're \
asking of me - in the last diff, I'm not touching the pot file at all.</p></pre> </blockquote>
<p>On març 2nd, 2015, 8:54 a.m. UTC, <b>Luigi Toscano</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; \
white-space: -o-pre-wrap; word-wrap: break-word;">Sorry again, it' s a bit.more complicated \
as there is already such _qt.pot file (the main one). So probably it should be extended to \
extract also runtime translations and the appropriate changes to translations domain applied \
here. Please cc i18n, I can't do a complete check now.</pre> </blockquote>
<p>On març 2nd, 2015, 8:58 a.m. UTC, <b>Luigi Toscano</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; \
white-space: -o-pre-wrap; word-wrap: break-word;">wrt why I'm asking: the Messages.sh, \
maybe the top-level one and few cmake calls to be changed to have translations working. Plase \
add i18n group.</pre> </blockquote>
<p>On març 2nd, 2015, 11:23 a.m. UTC, <b>Hrvoje Senjan</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; \
white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">i'd like to mention that \
translations for the daemon aren't working anyway with 5.7.0 tar, as they aren't wrapped with \
ki18n macro, but with ECMPoQmTools</p></pre> </blockquote>
<p>On març 2nd, 2015, 11:33 a.m. UTC, <b>Albert Astals Cid</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; \
white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">@Hrvoje, the daemon is using i18n \
just fine in 5.7.0, ecmpoqmtools is for the library which uses .po.</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">@Jerome, yes \
this change is incomplete, you either need to remove the Messages.sh in the daemon and add the \
ecm loading of the existing kglobalaccel5_qt qm to the daemon or create two different catalogs, \
i'd say having just one probably makes sense. You won't need -DTRANSLATION_DOMAIN anymore since \
that's for ki18n</p></pre> </blockquote>
<p>On març 2nd, 2015, 11:37 a.m. UTC, <b>Hrvoje Senjan</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; \
white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">afaics, ki18n only knowns about \
mo files, while all translations in kglobalaccel 5.7 are installed as qm files.. it is also \
possible i missunderstood something ;-)</p></pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; \
white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">You're right, the cmake code is \
wrong and is installing kglobalaccel5.po wrongly as kglobalaccel5.qm I guess noone expected .qm \
and non .qm files to coexist in a single tarball.</p></pre> <br />
<p>- Albert</p>
<br />
<p>On març 2nd, 2015, 9 a.m. UTC, Jerome Leclanche wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px \
#888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Frameworks, Localization and Translation (l10n), Martin Gräßlin, \
and Martin Klapetek.</div> <div>By Jerome Leclanche.</div>
<p style="color: grey;"><i>Updated mar. 2, 2015, 9 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kglobalaccel
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px \
solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Remove the \
runtime's KAboutData
The about data was unexposed, but created a dependency on KCoreAddons (for
KAboutData) and in turn on KI18n for the translations of the aboutData.
This removes both dependencies as well as the string extraction scripts.
--
Author notes: This is a RFC. We don't use kglobalaccel in LXQt but we would
like to, however it currently has too many dependencies. See
https://github.com/lxde/lxqt/issues/507 for related discussion.
I'm unsure myself if the about data is actually exposed somewhere I completely
missed, but it doesn't look that way.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid \
#b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Compiles and \
runs. No further testing done.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(68ad795)</span></li>
<li>src/runtime/CMakeLists.txt <span style="color: grey">(e639fa5)</span></li>
<li>src/runtime/globalshortcutsregistry.cpp <span style="color: grey">(3e4d720)</span></li>
<li>src/runtime/kglobalacceld.cpp <span style="color: grey">(4e7cb9d)</span></li>
<li>src/runtime/main.cpp <span style="color: grey">(fdf4d62)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/122680/diff/" style="margin-left: 3em;">View \
Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============0278066915786504254==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic