[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-i18n-doc
Subject: Re: Review Request 121372: Differeniate between bookmarks for documents and the web
From: "Gun Chleoc" <fios () foramnagaidhlig ! net>
Date: 2014-12-09 10:07:20
Message-ID: 20141209100720.4027.15327 () probe ! kde ! org
[Download RAW message or body]
--===============4785747909569242320==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
> On Dec. 8, 2014, 8:40 p.m., Albert Astals Cid wrote:
> > I don't think this makes sense at a framework level. If some application is so \
> > special that really needs a special case, they can call setText over the kaction \
> > themselves, otherwise we're going to end up havin 20 different "Add Bookmark" for \
> > all the minor technicalities of over what it is applied.
>
> Gun Chleoc wrote:
> I'm the person who originally filed the bug. Since I'm just translating and new to \
> KDE, can you give me a recommendation if I should translate this as "bookmarks" or \
> "webmarks" then? I don't know if web or document applications are more frequent in \
> KDE, and we should minimize the number of applications that I will have to file \
> bugs with. This is a linguistic issue rather than an application being "special" - \
> English is just more ambiguous than my language in this case.
> Albert Astals Cid wrote:
> You should translate bookmark. If you need bookmark in a web application to be \
> translatable different than bookmark, then file a bug agains that application and \
> ask them to. I am unconvinced a framework has to support all the combinatorials of \
> application use of bookmark multiplied by the various languages that can have \
> different translations for the various uses of bookrmak in various cases.
> Matthew Dawson wrote:
> Based on these comments then, I'm going to discard this RR and close the bug as \
> WONTFIX with a pointer back to here. Thanks for the help!
Thank you for your help and sorry for the extra coding work that won't be used now.
- Gun
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121372/#review71585
-----------------------------------------------------------
On Dec. 9, 2014, 4:41 a.m., Matthew Dawson wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121372/
> -----------------------------------------------------------
>
> (Updated Dec. 9, 2014, 4:41 a.m.)
>
>
> Review request for KDE Frameworks, Localization and Translation (l10n) and Matthew \
> Dawson.
>
> Bugs: 341279
> https://bugs.kde.org/show_bug.cgi?id=341279
>
>
> Repository: kconfig
>
>
> Description
> -------
>
> As requested in bug #1164383, this adds a new standard shortcut
> for adding bookmarks for web pages.
>
> BUG: 1164383
>
> I'm not sure if this is the best approach. If this is accpted, I'll commit a \
> similar change into KConfigWidgets.
>
> Diffs
> -----
>
> src/gui/kstandardshortcut.h 5bb07fb9f060b0d5950aed251da985ce3aa46661
> src/gui/kstandardshortcut.cpp 84007374c2836c1d61cb9b9361bd4217aa4ddc32
>
> Diff: https://git.reviewboard.kde.org/r/121372/diff/
>
>
> Testing
> -------
>
> Compiles, verified context extracted properly into pot file.
>
>
> Thanks,
>
> Matthew Dawson
>
>
--===============4785747909569242320==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/121372/">https://git.reviewboard.kde.org/r/121372/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On December 8th, 2014, 8:40 p.m. UTC, <b>Albert \
Astals Cid</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px \
solid #d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">I don't think this makes sense at a framework level. \
If some application is so special that really needs a special case, they can call \
setText over the kaction themselves, otherwise we're going to end up havin 20 \
different "Add Bookmark" for all the minor technicalities of over what it is \
applied.</p></pre> </blockquote>
<p>On December 8th, 2014, 9:22 p.m. UTC, <b>Gun Chleoc</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I'm \
the person who originally filed the bug. Since I'm just translating and new to KDE, \
can you give me a recommendation if I should translate this as "bookmarks" or \
"webmarks" then? I don't know if web or document applications are more frequent in \
KDE, and we should minimize the number of applications that I will have to file bugs \
with. This is a linguistic issue rather than an application being "special" - English \
is just more ambiguous than my language in this case.</p></pre> </blockquote>
<p>On December 8th, 2014, 9:27 p.m. UTC, <b>Albert Astals Cid</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">You \
should translate bookmark. If you need bookmark in a web application to be \
translatable different than bookmark, then file a bug agains that application and ask \
them to. I am unconvinced a framework has to support all the combinatorials of \
application use of bookmark multiplied by the various languages that can have \
different translations for the various uses of bookrmak in various cases.</p></pre> \
</blockquote>
<p>On December 9th, 2014, 4:41 a.m. UTC, <b>Matthew Dawson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Based \
on these comments then, I'm going to discard this RR and close the bug as WONTFIX \
with a pointer back to here. Thanks for the help!</p></pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Thank \
you for your help and sorry for the extra coding work that won't be used \
now.</p></pre> <br />
<p>- Gun</p>
<br />
<p>On December 9th, 2014, 4:41 a.m. UTC, Matthew Dawson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Frameworks, Localization and Translation (l10n) and \
Matthew Dawson.</div> <div>By Matthew Dawson.</div>
<p style="color: grey;"><i>Updated Dec. 9, 2014, 4:41 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=341279">341279</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kconfig
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">As requested in bug #1164383, this adds a new standard \
shortcut for adding bookmarks for web pages.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">BUG: 1164383</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">I'm not sure if this is \
the best approach. If this is accpted, I'll commit a similar change into \
KConfigWidgets.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Compiles, verified context extracted properly into pot \
file.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/gui/kstandardshortcut.h <span style="color: \
grey">(5bb07fb9f060b0d5950aed251da985ce3aa46661)</span></li>
<li>src/gui/kstandardshortcut.cpp <span style="color: \
grey">(84007374c2836c1d61cb9b9361bd4217aa4ddc32)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/121372/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============4785747909569242320==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic