[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-i18n-doc
Subject:    Re: Translation of application.desktop files
From:       Albert Astals Cid <aacid () kde ! org>
Date:       2014-11-13 23:57:43
Message-ID: 1733139.MlUZiHQduc () xps
[Download RAW message or body]

El Dijous, 13 de novembre de 2014, a les 19:23:41, Aleix Pol va escriure:
> On Thu, Nov 13, 2014 at 3:47 PM, Albert Astals Cid <aacid@kde.org> wrote:
> > El Dimecres, 8 d'octubre de 2014, a les 22:21:55, Albert Astals Cid va
> > 
> > escriure:
> > > El Dimecres, 8 d'octubre de 2014, a les 14:53:09, Burkhard Lück va
> > 
> > escriure:
> > > > Am Mittwoch, 8. Oktober 2014, 11:55:23 schrieb Aleix Pol:
> > > > > Hi,
> > > > > I've received this bug report [1]. It's about how some languages
> > > > > have
> > > > > translated the ;separed values in the category with coma instead of
> > > > > semi-colon.
> > > > 
> > > > This is about translations of msgids with msgctxt =
> > > > X-KDE-Keywords|Keywords
> > > > ?
> > > > 
> > > > Searching for msgids in l10n-kde4/templates/messages/ shows:
> > > > X-KDE-Keywords + comma separator = 92x
> > > > X-KDE-Keywords + semicolon separator = 1x
> > > > Keywords + comma separator = 1x
> > > > Keywords + semicolon separator = 7x
> > > > 
> > > > muon-discover.desktop and muon-installer.desktop use semicolon as
> > > > separator
> > > > and have a trailing semicolon for "Keywords" entries
> > > > muon.desktop has comma as separator and missing trailing semicolon for
> > > > "X-KDE- Keywords" entries
> > > > 
> > > > desktop-file-validate apparently does check only missing for missing
> > > > trailing semicolon in app desktop files with "Keywords", not for the
> > 
> > kind
> > 
> > > > of separator
> > > > 
> > > > desktop-entry-spec-1.1.html says:
> > > > "multiple values should be separated by a semicolon"
> > > > and
> > > > "KDE also used the Keywords key before it was standardized, using
> > 
> > commas
> > 
> > > > instead of semi-colons as separators. At the time of standardization,
> > 
> > the
> > 
> > > > field had been prefixed with a X-KDE prefix, but the Trinity fork
> > > > still
> > > > used the non- prefixed variant."
> > > > 
> > > > > How can we do to fix this?
> > > > > Also maybe it's a problem in other places, maybe we can have a check
> > 
> > or
> > 
> > > > > something, for desktop files...
> > > > 
> > > > A check is obviously needed, but what is the correct separator and
> > > > trailing
> > > > char to be used?
> > > 
> > > Right i see, this is a bit confusing, maybe it's , for X-KDE-Keywords
> > 
> > and ;
> > 
> > > for Keywords?
> > > 
> > > Aleix can you read the code that parses that and confirm?
> > 
> > Ping?
> > 
> > Cheers,
> > 
> >   Albert
> >   
> > > Cheers,
> > > 
> > >   Albert
> 
> Uh sorry.
> 
> Yes, just checked, this is the line that gets the keywords:
> kservice/src/services/kservice.cpp:178:    m_lstKeywords +=
> desktopGroup.readEntry("X-KDE-Keywords", QStringList());
> 
> This takes us to KConfig to check how readEntry<QStringList> works, which
> uses KConfigGroupPrivate::deserializeList.
> This one seems to split using ',' as we can see in kconfiggroup.cpp:172.
> 
> So yes, I guess ; need to be changed.

Ok, so to be clear:
  X-KDE-Keywords uses , for separation
  Keywords uses ; for separation

Now we need some to validate all the .desktop files (or at least the 
translations) :D

Chusslove is this something pology can do?

Cheers,
  Albert

> 
> Aleix
> 
> PS: My apologies and thanks for kicking my ass and making me look >.<

[prev in list] [next in list] [prev in thread] [next in thread]