--===============1936485909280023572== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120353/ ----------------------------------------------------------- (Updated Sept. 25, 2014, 4:07 p.m.) Status ------ This change has been marked as submitted. Review request for Localization and Translation (l10n) and Plasma. Repository: plasma-workspace Description ------- So in Plasma 5 we're adding support for timezones into the clock applet. It's based on QTimeZone and that uses IDs which are consisting of "Continent/City". Qt has no accessor methods for getting the city of the given timezone so we're parsing the timezone ID and using the part after "/" as the city and we display that in the UI. We want those cities translated however so it can display eg. "Praha" instead of "Prague" for Czech users. So I've created this helper class which has a dictionary of timezone-id-city<-->i18n(city) and this is then used in the UI. I'm not sure where exactly to put it, I'd prefer KI18n framework but as we would like to have this in Plasma 5.1 release, I put it together with the applet as Plasma 5.1 does not (and probably will not) depend on KI18n 5.3. I'm adding the l10n group to the reviewers - guys can you please comment/+1 this? If this is deemed good enough, I'd like to also add the country and continent i18n functions into that class afterwards. Diffs ----- applets/digital-clock/package/contents/ui/DigitalClock.qml f26ba9f applets/digital-clock/plugin/CMakeLists.txt 1c11abe applets/digital-clock/plugin/digitalclockplugin.cpp f347ee9 applets/digital-clock/plugin/timezonemodel.h e1f53c5 applets/digital-clock/plugin/timezonemodel.cpp 1fbab09 applets/digital-clock/plugin/timezonesi18n.h PRE-CREATION applets/digital-clock/plugin/timezonesi18n.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/120353/diff/ Testing ------- Thanks, Martin Klapetek --===============1936485909280023572== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 7bit

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120353/

This change has been marked as submitted.

Review request for Localization and Translation (l10n) and Plasma.

By Martin Klapetek.

Updated Sept. 25, 2014, 4:07 p.m.

Repository: plasma-workspace

Description

So in Plasma 5 we're adding support for timezones into the clock applet. It's based on QTimeZone and that uses IDs which are consisting of "Continent/City". Qt has no accessor methods for getting the city of the given timezone so we're parsing the timezone ID and using the part after "/" as the city and we display that in the UI.
We want those cities translated however so it can display eg. "Praha" instead of "Prague" for Czech users. So I've created this helper class which has a dictionary of timezone-id-city<-->i18n(city) and this is then used in the UI. I'm not sure where exactly to put it, I'd prefer KI18n framework but as we would like to have this in Plasma 5.1 release, I put it together with the applet as Plasma 5.1 does not (and probably will not) depend on KI18n 5.3.
I'm adding the l10n group to the reviewers - guys can you please comment/+1 this?
If this is deemed good enough, I'd like to also add the country and continent i18n functions into that class afterwards.

Diffs

applets/digital-clock/package/contents/ui/DigitalClock.qml (f26ba9f)
applets/digital-clock/plugin/CMakeLists.txt (1c11abe)
applets/digital-clock/plugin/digitalclockplugin.cpp (f347ee9)
applets/digital-clock/plugin/timezonemodel.h (e1f53c5)
applets/digital-clock/plugin/timezonemodel.cpp (1fbab09)
applets/digital-clock/plugin/timezonesi18n.h (PRE-CREATION)
applets/digital-clock/plugin/timezonesi18n.cpp (PRE-CREATION)

--===============1936485909280023572==--