[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-i18n-doc
Subject:    Re: Review Request 7117: autogen.sh: Fix generated CMakeLists.txt: always supply kdoctools_create_ha
From:       "Luigi Toscano" <luigi.toscano () tiscali ! it>
Date:       2014-08-03 21:17:57
Message-ID: 20140803211757.20976.57527 () probe ! kde ! org
[Download RAW message or body]

--===============0019560399345215198==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://svn.reviewboard.kde.org/r/7117/#review11128
-----------------------------------------------------------

Ship it!


If it's mandatory, it's mandatory :)

- Luigi Toscano


On Ago. 3, 2014, 9:11 a.m., Alexander Potashev wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://svn.reviewboard.kde.org/r/7117/
> -----------------------------------------------------------
> 
> (Updated Ago. 3, 2014, 9:11 a.m.)
> 
> 
> Review request for Localization and Translation (l10n), Aurélien Gâteau, Aleix \
> Pol, and Lukáš Tinkl. 
> 
> Repository: kde
> 
> 
> Description
> -------
> 
> In previous version of autogen.sh the generated CMakeLists.txt contained calls to \
> kdoctools_create_handbook() without argument "SUBDIR". This argument is required \
> since https://git.reviewboard.kde.org/r/118156/ 
> 
> Diffs
> -----
> 
> trunk/l10n-kf5/scripts/autogen.sh 1395648 
> 
> Diff: https://svn.reviewboard.kde.org/r/7117/diff/
> 
> 
> Testing
> -------
> 
> Successfully generated CMakeLists.txt files for Ukrainian localization using \
> "./autogen.sh uk" and built the Ukrainian localization files using cmake. 
> 
> Thanks,
> 
> Alexander Potashev
> 
> 


--===============0019560399345215198==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit




<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://svn.reviewboard.kde.org/r/7117/">https://svn.reviewboard.kde.org/r/7117/</a>
  </td>
    </tr>
   </table>
   <br />



 <p>Ship it!</p>



 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">If \
it's mandatory, it's mandatory :)</p></pre>  <br />









<p>- Luigi Toscano</p>


<br />
<p>On agosto 3rd, 2014, 9:11 a.m. UTC, Alexander Potashev wrote:</p>









<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Localization and Translation (l10n), Aurélien Gâteau, Aleix \
Pol, and Lukáš Tinkl.</div> <div>By Alexander Potashev.</div>


<p style="color: grey;"><i>Updated Ago. 3, 2014, 9:11 a.m.</i></p>









<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kde
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">In previous version of autogen.sh the generated \
CMakeLists.txt contained calls to kdoctools_create_handbook() without argument \
"SUBDIR". This argument is required since \
https://git.reviewboard.kde.org/r/118156/</p></pre>  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Successfully generated CMakeLists.txt files for \
Ukrainian localization using "./autogen.sh uk" and built the Ukrainian localization \
files using cmake.</p></pre>  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>trunk/l10n-kf5/scripts/autogen.sh <span style="color: \
grey">(1395648)</span></li>

</ul>

<p><a href="https://svn.reviewboard.kde.org/r/7117/diff/" style="margin-left: \
3em;">View Diff</a></p>






  </td>
 </tr>
</table>








  </div>
 </body>
</html>


--===============0019560399345215198==--


[prev in list] [next in list] [prev in thread] [next in thread] 

Configure | About | News | Add a list | Sponsored by KoreLogic