[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-i18n-doc
Subject:    String Freeze Exception in Baloo
From:       Vishesh Handa <me () vhanda ! in>
Date:       2014-07-28 14:16:28
Message-ID: CAOPTMKA+o7kpoQ0TTd-Qyu10FKodhUN02VcEhBW52vLYSWYNig () mail ! gmail ! com
[Download RAW message or body]

Hey guys

We introduced a new query parser module in Baloo for 4.14. This module used
'%1' as a placeholder in many of the strings. This '%1' was just a
placeholder. Unfortunately, KLocalizedString when compiled in release mode
would replace this %1 with K18N_ARGUMENT_MISSING, making the module useless.

If it's alright with you guys, I would like to stop using %1 in our strings
and now use $ instead. See - https://git.reviewboard.kde.org/r/119519/

This would unfortunately break many of the existing translations. Possible
options -

1. Break the translations. This module isn't publicly used anywhere.
Doesn't matter.
2. Do not ship the module for 4.14. It's not used anywhere, so we can do
that.

I would prefer doing (1). If there are no objections I'll commit the patch.

-- 
Vishesh Handa

[Attachment #3 (text/html)]

<div dir="ltr">Hey guys<div><br></div><div>We introduced a new query parser module in \
Baloo for 4.14. This module used &#39;%1&#39; as a placeholder in many of the \
strings. This &#39;%1&#39; was just a placeholder. Unfortunately, KLocalizedString \
when compiled in release mode would replace this %1 with K18N_ARGUMENT_MISSING, \
making the module useless.</div> <div><br></div><div>If it&#39;s alright with you \
guys, I would like to stop using %1 in our strings and now use $ instead. See -  <a \
href="https://git.reviewboard.kde.org/r/119519/">https://git.reviewboard.kde.org/r/119519/</a></div>
 <div><br></div><div>This would unfortunately break many of the existing \
translations. Possible options -</div><div><br></div><div>1. Break the translations. \
This module isn&#39;t publicly used anywhere. Doesn&#39;t matter.</div> <div>2. Do \
not ship the module for 4.14. It&#39;s not used anywhere, so we can do \
that.</div><div><br></div><div>I would prefer doing (1). If there are no objections \
I&#39;ll commit the patch.</div><div><div><br></div>-- <br> <span \
style="color:rgb(192,192,192)">Vishesh Handa</span><br> </div></div>



[prev in list] [next in list] [prev in thread] [next in thread]