[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-i18n-doc
Subject:    Re: Review Request 118338: [kwin] Streamline Comment fields of KCMs
From:       "David Edmundson" <david () davidedmundson ! co ! uk>
Date:       2014-06-04 12:51:12
Message-ID: 20140604125112.16795.3598 () probe ! kde ! org
[Download RAW message or body]

> On May 27, 2014, 7:03 a.m., Thomas Lübking wrote:
> > kcmkwin/kwinoptions/kwinmoving.desktop, line 100
> > <https://git.reviewboard.kde.org/r/118338/diff/1/?file=275212#file275212line100>
> > 
> > window movement control
> > controlled window movement
> > (it's snapping and geometry display)
> 
> Sebastian Kügler wrote:
> What's wrong with "Window Moving", still sounds like the cleanest to my ears from \
> all three options. 
> Thomas Lübking wrote:
> The page does only deals with controlling the window movement (position \
> visualization, snapping) not with window movement in general (eg. whether windows \
> are movable, alt+lmb configuration, shortcut, trigger delays, struts, etc) 
> Sebastian Kügler wrote:
> Neither is excluded by the text in the comment field. The underlying problem is \
> that we can only get close to the user's perception, but not precisely match in the \
> title what the more complex UI underneath is about. That can, if necessary be \
> explained in there, but the general hope that the UI is clear about its purpose \
> still holds. A concise title helps with that: The user will see "Window Moving" and \
> think "Ah, options related to moving windows around". It's a generalized grouping, \
> not much else. 
> I'll push this as-is, if you want to improve this further, be my guest.
> 
> David Edmundson wrote:
> > not with window movement in general 
> 
> So there's another KCM which deals with actions that are more closely linked to \
> window moving? 
> Thomas Lübking wrote:
> No, they're scattered around other page (mostly window actions, shortcuts are only \
> in the keys kcm) 
> But that's not what i meant nor said. There's also no page more closely linked to \
> cd recording, but i'd still not call this one "cd recording". 
> It's probably due to the comment-as-title "abuse" but as "comment", the strings \
> rather lost meaning.

What I meant was if other things are related to window moving in other places then I \
agree with you that it's wrong to use it here.

My Ship it! was merely that the English was fine from a native speakers perspective, \
which sebas and MG asked me to review. The layouts of your KCMs isn't something I \
know about.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118338/#review58537
-----------------------------------------------------------


On June 4, 2014, 11:32 a.m., Sebastian Kügler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118338/
> -----------------------------------------------------------
> 
> (Updated June 4, 2014, 11:32 a.m.)
> 
> 
> Review request for kwin, Localization and Translation (l10n) and KDE Usability.
> 
> 
> Repository: kwin
> 
> 
> Description
> -------
> 
> [kwin] Streamline Comment fields of KCMs
> 
> This patch applies a common language and type-setting to the
> systemsettings modules in kwin.
> 
> Considerations:
> - The comment field might repeat the name, or give more detail about the
> specific settings on this page, this makes sense with how
> systemsettings and kcmshell present it
> - Mentioning the words settings, configure, options, etc. is avoided --
> it is clear from the context that these are settings and options.
> - Title-case throughout in line with human interface guidelines, see
> http://techbase.kde.org/Projects/Usability/HIG/Capitalization
> - The comment ends up being the title, so the
> - tech slang is avoided as much as possible, but left in where really
> necessary
> - I've left the Name field "mostly untouched", as that one is key for
> the user to find the right module in systemsettings' icon view and in
> the sidebars
> 
> The most prominent change is "Compositor" to "Graphics Compositor" (in
> the Title field). This is more like a "suggestion", if you don't like
> it, I'll take it out again. Reasoning: "Compositor" is a very technical
> term, people who know graphics might recognize it. Others might not
> understand that "composite" is about graphics -- hence the
> specialization.
> 
> 
> Diffs
> -----
> 
> kcmkwin/kwinoptions/kwinfocus.desktop d50fb82 
> kcmkwin/kwinoptions/kwinmoving.desktop cd6dcbc 
> kcmkwin/kwinoptions/kwinoptions.desktop 6075a5c 
> kcmkwin/kwinrules/kwinrules.desktop cded437 
> kcmkwin/kwinscreenedges/kwinscreenedges.desktop 404f28a 
> kcmkwin/kwintabbox/kwintabbox.desktop 5955e10 
> kcmkwin/kwinoptions/kwinadvanced.desktop 6cbb95a 
> kcmkwin/kwindesktop/desktop.desktop 9e9506c 
> kcmkwin/kwinoptions/kwinactions.desktop 0ebd40c 
> kcmkwin/kwindecoration/kwindecoration.desktop 51a2034 
> kcmkwin/kwincompositing/kwincompositing.desktop 087b589 
> kcmkwin/kwincompositing/kcmkwineffects.desktop 390199b 
> 
> Diff: https://git.reviewboard.kde.org/r/118338/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sebastian Kügler
> 
> 


[Attachment #3 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/118338/">https://git.reviewboard.kde.org/r/118338/</a>
  </td>
    </tr>
   </table>
   <br />










<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <p style="margin-top: 0;">On May 27th, 2014, 7:03 a.m. UTC, <b>Thomas \
Lübking</b> wrote:</p>  <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">  



<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="https://git.reviewboard.kde.org/r/118338/diff/1/?file=275212#file275212line100" \
style="color: black; font-weight: bold; text-decoration: \
underline;">kcmkwin/kwinoptions/kwinmoving.desktop</a>  <span style="font-weight: \
normal;">

     (Diff revision 1)

    </span>
   </th>
  </tr>
 </thead>



 
 

 <tbody>

  <tr>
    <th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">100</font></th>  <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; ">Comment=Configure the way that \
windows are moved</pre></td>  <th bgcolor="#e9eaa8" style="border-left: 1px solid \
#C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">100</font></th>  <td bgcolor="#fdfebc" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; ">Comment=Window Moving</pre></td>  </tr>

 </tbody>

</table>

  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">window movement control \
controlled window movement (it&#39;s snapping and geometry display)</pre>
 </blockquote>



 <p>On May 27th, 2014, 3:50 p.m. UTC, <b>Sebastian Kügler</b> wrote:</p>
 <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">What&#39;s wrong with \
&quot;Window Moving&quot;, still sounds like the cleanest to my ears from all three \
options.</pre>  </blockquote>





 <p>On June 4th, 2014, 11:09 a.m. UTC, <b>Thomas Lübking</b> wrote:</p>
 <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The page does only deals \
with controlling the window movement (position visualization, snapping) not with \
window movement in general (eg. whether windows are movable, alt+lmb configuration, \
shortcut, trigger delays, struts, etc)</pre>  </blockquote>





 <p>On June 4th, 2014, 11:28 a.m. UTC, <b>Sebastian Kügler</b> wrote:</p>
 <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Neither is excluded by \
the text in the comment field. The underlying problem is that we can only get close \
to the user&#39;s perception, but not precisely match in the title what the more \
complex UI underneath is about. That can, if necessary be explained in there, but the \
general hope that the UI is clear about its purpose still holds. A concise title \
helps with that: The user will see &quot;Window Moving&quot; and think &quot;Ah, \
options related to moving windows around&quot;. It&#39;s a generalized grouping, not \
much else.

I&#39;ll push this as-is, if you want to improve this further, be my guest.</pre>
 </blockquote>





 <p>On June 4th, 2014, 12:13 p.m. UTC, <b>David Edmundson</b> wrote:</p>
 <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">&gt;not with window \
movement in general 

So there&#39;s another KCM which deals with actions that are more closely linked to \
window moving?</pre>  </blockquote>





 <p>On June 4th, 2014, 12:32 p.m. UTC, <b>Thomas Lübking</b> wrote:</p>
 <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">No, they&#39;re \
scattered around other page (mostly window actions, shortcuts are only in the keys \
kcm)

But that&#39;s not what i meant nor said. There&#39;s also no page more closely \
linked to cd recording, but i&#39;d still not call this one &quot;cd recording&quot;.

It&#39;s probably due to the comment-as-title &quot;abuse&quot; but as \
&quot;comment&quot;, the strings rather lost meaning.</pre>  </blockquote>







</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">What I \
meant was if other things are related to window moving in other places then I agree \
with you that it&#39;s wrong to use it here.

My Ship it! was merely that the English was fine from a native speakers perspective, \
which sebas and MG asked me to review. The layouts of your KCMs isn&#39;t something I \
know about. </pre>
<br />




<p>- David</p>


<br />
<p>On June 4th, 2014, 11:32 a.m. UTC, Sebastian Kügler wrote:</p>








<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kwin, Localization and Translation (l10n) and KDE \
Usability.</div> <div>By Sebastian Kügler.</div>


<p style="color: grey;"><i>Updated June 4, 2014, 11:32 a.m.</i></p>









<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kwin
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">[kwin] Streamline Comment fields of KCMs

This patch applies a common language and type-setting to the
systemsettings modules in kwin.

Considerations:
- The comment field might repeat the name, or give more detail about the
  specific settings on this page, this makes sense with how
  systemsettings and kcmshell present it
- Mentioning the words settings, configure, options, etc. is avoided --
  it is clear from the context that these are settings and options.
- Title-case throughout in line with human interface guidelines, see
  http://techbase.kde.org/Projects/Usability/HIG/Capitalization
- The comment ends up being the title, so the
- tech slang is avoided as much as possible, but left in where really
  necessary
- I&#39;ve left the Name field &quot;mostly untouched&quot;, as that one is key for
  the user to find the right module in systemsettings&#39; icon view and in
  the sidebars

The most prominent change is &quot;Compositor&quot; to &quot;Graphics \
Compositor&quot; (in the Title field). This is more like a &quot;suggestion&quot;, if \
you don&#39;t like it, I&#39;ll take it out again. Reasoning: &quot;Compositor&quot; \
is a very technical term, people who know graphics might recognize it. Others might \
not understand that &quot;composite&quot; is about graphics -- hence the
specialization.</pre>
  </td>
 </tr>
</table>



<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kcmkwin/kwinoptions/kwinfocus.desktop <span style="color: \
grey">(d50fb82)</span></li>

 <li>kcmkwin/kwinoptions/kwinmoving.desktop <span style="color: \
grey">(cd6dcbc)</span></li>

 <li>kcmkwin/kwinoptions/kwinoptions.desktop <span style="color: \
grey">(6075a5c)</span></li>

 <li>kcmkwin/kwinrules/kwinrules.desktop <span style="color: \
grey">(cded437)</span></li>

 <li>kcmkwin/kwinscreenedges/kwinscreenedges.desktop <span style="color: \
grey">(404f28a)</span></li>

 <li>kcmkwin/kwintabbox/kwintabbox.desktop <span style="color: \
grey">(5955e10)</span></li>

 <li>kcmkwin/kwinoptions/kwinadvanced.desktop <span style="color: \
grey">(6cbb95a)</span></li>

 <li>kcmkwin/kwindesktop/desktop.desktop <span style="color: \
grey">(9e9506c)</span></li>

 <li>kcmkwin/kwinoptions/kwinactions.desktop <span style="color: \
grey">(0ebd40c)</span></li>

 <li>kcmkwin/kwindecoration/kwindecoration.desktop <span style="color: \
grey">(51a2034)</span></li>

 <li>kcmkwin/kwincompositing/kwincompositing.desktop <span style="color: \
grey">(087b589)</span></li>

 <li>kcmkwin/kwincompositing/kcmkwineffects.desktop <span style="color: \
grey">(390199b)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/118338/diff/" style="margin-left: \
3em;">View Diff</a></p>







  </td>
 </tr>
</table>








  </div>
 </body>
</html>



[prev in list] [next in list] [prev in thread] [next in thread] 

Configure | About | News | Add a list | Sponsored by KoreLogic