[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-i18n-doc
Subject: Re: Review Request 7111: extract-tr-strings: Cleanup source code references in *_qt.po files
From: "Alexander Potashev" <aspotashev () gmail ! com>
Date: 2014-05-19 18:34:19
Message-ID: 20140519183419.9349.16375 () probe ! kde ! org
[Download RAW message or body]
> On May 18, 2014, 11:46 p.m., Alexander Potashev wrote:
> > P.S. Aurélien, is there any strong reason why we are using the custom script \
> > "extract-tr-strings" instead of XGETTEXT_QT? (Like in the Qt-based part of \
> > Marble, see Messages.sh in the Marble repository.)
>
> Aurélien Gâteau wrote:
> If I am not mistaken, I was adviced by Albert not to use it. I see you added him to \
> this request so he can probably provide a better reasoning.
> Alexander Potashev wrote:
> I expect he could say that `lupdate` is a native application supported by Qt \
> developers, and in contrast, in gettext some features might be missing or being \
> implemented only after a while as they appear in Qt.
> Albert Astals Cid wrote:
> How do you create a proper .qm you can use using XGETTEXT_QT ? You can't.
Oh, sorry for the confusion. I thought that e.g. Marble loads a .qm file, but it \
doesn't.
- Alexander
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://svn.reviewboard.kde.org/r/7111/#review11111
-----------------------------------------------------------
On May 18, 2014, 11:44 p.m., Alexander Potashev wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://svn.reviewboard.kde.org/r/7111/
> -----------------------------------------------------------
>
> (Updated May 18, 2014, 11:44 p.m.)
>
>
> Review request for Localization and Translation (l10n), Aurélien Gâteau and \
> Albert Astals Cid.
>
> Repository: kde
>
>
> Description
> -------
>
> Cleanup source code references in *_qt.po files generated with "extract-tr-strings"
>
> Filenames in source code references should be represented as relative paths
> with respect to the location of Messages.sh.
>
>
> Diffs
> -----
>
> trunk/l10n-kf5/scripts/extract-tr-strings 1387292
> trunk/l10n-kf5/scripts/strip_ts_source_path_prefix.xsl PRE-CREATION
>
> Diff: https://svn.reviewboard.kde.org/r/7111/diff/
>
>
> Testing
> -------
>
> Ran ./Messages.sh in the source code repository for KAuth5 framework in its \
> subdirectory "src". All directory elements upper than Messages.sh are stripped, \
> including "/src/", e.g.:
> -#: ../../home/scripty/prod/git-unstable/frameworks_kauth/src/backends/dbus/DBusHelperProxy.cpp:76
> +#: backends/dbus/DBusHelperProxy.cpp:76
> msgctxt "KAuth::DBusHelperProxy|"
> msgid "DBus Backend error: connection to helper failed. "
> msgstr ""
>
>
> Thanks,
>
> Alexander Potashev
>
>
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://svn.reviewboard.kde.org/r/7111/">https://svn.reviewboard.kde.org/r/7111/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On May 18th, 2014, 11:46 p.m. UTC, <b>Alexander \
Potashev</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">P.S. Aurélien, is there any strong reason why we are using the custom \
script "extract-tr-strings" instead of XGETTEXT_QT? (Like in the Qt-based \
part of Marble, see Messages.sh in the Marble repository.)</pre> </blockquote>
<p>On May 19th, 2014, 2:34 p.m. UTC, <b>Aurélien Gâteau</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">If I am not mistaken, I \
was adviced by Albert not to use it. I see you added him to this request so he can \
probably provide a better reasoning.</pre> </blockquote>
<p>On May 19th, 2014, 5:33 p.m. UTC, <b>Alexander Potashev</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I expect he could say \
that `lupdate` is a native application supported by Qt developers, and in contrast, \
in gettext some features might be missing or being implemented only after a while as \
they appear in Qt.</pre> </blockquote>
<p>On May 19th, 2014, 6:26 p.m. UTC, <b>Albert Astals Cid</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">How do you create a \
proper .qm you can use using XGETTEXT_QT ? You can't.</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Oh, sorry for the \
confusion. I thought that e.g. Marble loads a .qm file, but it doesn't.</pre> <br \
/>
<p>- Alexander</p>
<br />
<p>On May 18th, 2014, 11:44 p.m. UTC, Alexander Potashev wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://svn.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Localization and Translation (l10n), Aurélien Gâteau and \
Albert Astals Cid.</div> <div>By Alexander Potashev.</div>
<p style="color: grey;"><i>Updated May 18, 2014, 11:44 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kde
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Cleanup source code references in *_qt.po files generated with \
"extract-tr-strings"
Filenames in source code references should be represented as relative paths
with respect to the location of Messages.sh.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Ran ./Messages.sh in the source code repository for KAuth5 framework in \
its subdirectory "src". All directory elements upper than Messages.sh are \
stripped, including "/src/", e.g.:
-#: ../../home/scripty/prod/git-unstable/frameworks_kauth/src/backends/dbus/DBusHelperProxy.cpp:76
+#: backends/dbus/DBusHelperProxy.cpp:76
msgctxt "KAuth::DBusHelperProxy|"
msgid "DBus Backend error: connection to helper failed. "
msgstr ""
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>trunk/l10n-kf5/scripts/extract-tr-strings <span style="color: \
grey">(1387292)</span></li>
<li>trunk/l10n-kf5/scripts/strip_ts_source_path_prefix.xsl <span style="color: \
grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://svn.reviewboard.kde.org/r/7111/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic