From kde-i18n-doc  Tue Apr 15 13:14:53 2014
From: =?UTF-8?B?QXVyw6lsaWVuIEfDonRlYXU=?= <agateau () kde ! org>
Date: Tue, 15 Apr 2014 13:14:53 +0000
To: kde-i18n-doc
Subject: Re: [PATCH] Port autogen.sh to ECM
Message-Id: <lijbcg$9cb$1 () ger ! gmane ! org>
X-MARC-Message: https://marc.info/?l=kde-i18n-doc&m=139756773123088

Burkhard Lück wrote:

> Am Montag, 14. April 2014, 13:12:30 schrieb Aurélien Gâteau:
>> Hi,
>> 
>> Attached patch ports l1On-kf5/scripts/autogen.sh to ECM.
>> 
>> For the sake of simplification, I replaced calls to
>> macro_optional_add_subdirectory() with calls to add_subdirectory() since
>> the code generating the CMakeLists.txt checks the directory exists before
>> adding an add_subdirectory()" call.
>> 
>> I tested it with a handful of messages and doc .po. There is an issue
>> with doc installation failing to create a "common" symlink, but the
>> problem needs to be fixed in kdoctools as far as I understand.
>> 
> Please commit
> 
>> Assuming this patch is OK for you, would you mind if I also create a
>> separate commit to fix the indentation? The current inconsistent mix of
>> tabs and spaces makes it annoying to work with.
>> 
> OK.

Just did so. I also removed some dead code, which dated from when KDE was 
still using automake.

Aurélien