[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-i18n-doc
Subject:    Re: KSysGuard untranslated strings
From:       Yuri Chornoivan <yurchor () ukr ! net>
Date:       2014-01-15 17:49:58
Message-ID: 3209942.fJqrftN2Is () localhost ! localdomain
[Download RAW message or body]

середа, 15-січ-2014 16:43:23 Yuri Chornoivan написано:
> Wed, 15 Jan 2014 16:27:41 +0200 було написано Volkan Gezer
> 
> <volkangezer@gmail.com>:
> > 2014/1/12 John Tapsell <johnflux@gmail.com>:
> >> Patch looks good to me, but can't the two attr arguments be merged into
> >> one?
> > 
> > Is there any review request for this patch or should we create one?
> 
> I cannot test the compilation with the full version of the patch in my KDE
> 4.10.5 system and do not know if attr arguments can be merged. Thus, there
> is no RR yet. Sorry. :'(
> 
> Many thanks in advance if someone can test and create review request.
> 
> Best regards,
> Yuri

For the reference, the patch against kde-workspace is attached. I'm not sure 
if it even compiles. Thanks for testing.

Best regards,
Yuri

> 
> >> On 12 January 2014 14:44, John Tapsell <johnflux@gmail.com> wrote:
> >>> Yep.  I meant more that the ksysguardd files wouldn't be it.
> >>> 
> >>> On 12 January 2014 14:17, Yuri Chornoivan <yurchor@ukr.net> wrote:
> >>>> написане Sun, 12 Jan 2014 15:24:42 +0200, John Tapsell
> >>>> 
> >>>> <johnflux@gmail.com>:
> >>>>> Only the .sgrd file is relevant here actually.
> >>>> 
> >>>> Hi,
> >>>> 
> >>>> Not really. Adding summationName to extraction (patch attached) and
> >>>> proper sensor->summationName wrapping into i18n with
> >>>> toUtf8().constData() in
> >>>> FancyPlotter.cpp:528 can be used for translation of 4 strings:
> >>>> 
> >>>> "Memory"
> >>>> "Swap"
> >>>> "Receiving"
> >>>> "Sending"
> >>>> 
> >>>> The string "Used Swap Memory" is from Memory.c.
> >>>> 
> >>>> Just my 2 cents.
> >>>> 
> >>>> Best regards,
> >>>> Yuri
> >>>> 
> >>>>> On 11 January 2014 15:31, Burkhard Lück <lueck@hube-lueck.de> wrote:
> >>>>>> Am Samstag, 11. Januar 2014, 16:17:48 schrieb Albert Astals Cid:
> >>>>>> > El Dissabte, 11 de gener de 2014, a les 16:01:03, Volkan Gezer va
> >>>>>> 
> >>>>>> escriure:
> >>>>>> > > Hello,
> >>>>>> > > 
> >>>>>> > > In KSysGuard -> System Load, hovering over Memory and Swap
> >>>>>> 
> >>>>>> section
> >>>>>> 
> >>>>>> > > graph gives English "Used Swap Memory" string. I an unable to
> >>>>>> > > locate
> >>>>>> > > this string cannot in templates. On the same tab, Network
> >>>>>> 
> >>>>>> History
> >>>>>> 
> >>>>>> > > shows English "Receiving" and "Sending" strings as well.
> >>>>>> > > 
> >>>>>> > > Is it possible to fix those?
> >>>>>> > 
> >>>>>> > I guess this is https://bugs.kde.org/show_bug.cgi?id=306243 ?
> >>>>>> 
> >>>>>> No, these strings are not extracted and can be found in:
> >>>>>> 
> >>>>>> ksysguard/ksysguardd/FreeBSD/Memory.c
> >>>>>> ksysguard/ksysguardd/OpenBSD/memory.c
> >>>>>> ksysguard/ksysguardd/NetBSD/Memory.c
> >>>>>> ksysguard/ksysguardd/Linux/Memory.c
> >>>>>> ksysguard/gui/SystemLoad2.sgrd
> >>>>>> 
> >>>>>> --
> >>>>>> Burkhard Lück
["loc.patch" (loc.patch)]

diff --git a/ksysguard/gui/Messages.sh b/ksysguard/gui/Messages.sh
index a1f1f3a..d07046f 100644
--- a/ksysguard/gui/Messages.sh
+++ b/ksysguard/gui/Messages.sh
@@ -1,5 +1,5 @@
 #! /usr/bin/env bash
 $EXTRACTRC `find . -name "*.ui" -o -name "*.rc"` >> rc.cpp || exit 11
-$EXTRACTATTR --attr="WorkSheet,title" --attr="display,title" `find . -name "*.sgrd"` \
>> rc.cpp || exit 13 +$EXTRACTATTR --attr="WorkSheet,title" --attr="display,title" \
> > --attr="beam,summationName" `find . -name "*.sgrd"` >> rc.cpp || exit 13
 $XGETTEXT `find . -name "*.cpp"` -o $podir/ksysguard.pot
 rm -f rc.cpp
diff --git a/ksysguard/gui/SensorDisplayLib/FancyPlotter.cpp \
b/ksysguard/gui/SensorDisplayLib/FancyPlotter.cpp index 1e770c3..0b59e77 100644
--- a/ksysguard/gui/SensorDisplayLib/FancyPlotter.cpp
+++ b/ksysguard/gui/SensorDisplayLib/FancyPlotter.cpp
@@ -525,7 +525,7 @@ void FancyPlotter::setTooltip()
         }
         if (beamId != sensor->beamId) {
             if (!sensor->summationName.isEmpty()) {
-                tooltip += i18nc("%1 is what is being shown statistics for, like \
'Memory', 'Swap', etc.", "<p><b>%1:</b><br>", sensor->summationName); +               \
tooltip += i18nc("%1 is what is being shown statistics for, like 'Memory', 'Swap', \
etc.", "<p><b>%1:</b><br>", i18n(sensor->summationName.toUtf8().constData()));  \
showingSummationGroup = true;  neednewline = false;
             } else if (showingSummationGroup) {



[prev in list] [next in list] [prev in thread] [next in thread]