[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-i18n-doc
Subject:    Re: [kdepim-runtime] agents/maildispatcher: in postJobResult(),
From:       Allen Winter <winter () kde ! org>
Date:       2011-11-19 13:28:02
Message-ID: 201111190828.03252.winter () kde ! org
[Download RAW message or body]

On Friday 18 November 2011 4:53:13 PM Allen Winter wrote:
> Git commit 8492b463dc12f7aacca5e29905ccf5c5b6cf4202 by Allen Winter.
> Committed on 18/11/2011 at 22:49.
> Pushed by winterz into branch 'master'.
> 
> in postJobResult(), try to give a more specific reason why sending
> might fail, instead of just saying "unable to finalize".
> 
> CCMAIL: kde-i18n-doc@kde.org. Sorry I had to do this but users
> are complaining that they aren't able to send mail and we really
> need to know what's going on.
> 
Looking at this in the light of day, the new i18n look like a word-puzzle.
I'll do soemthing better.


> M  +14   -1    agents/maildispatcher/sendjob.cpp
> 
> http://commits.kde.org/kdepim-runtime/8492b463dc12f7aacca5e29905ccf5c5b6cf4202
> 
> diff --git a/agents/maildispatcher/sendjob.cpp b/agents/maildispatcher/sendjob.cpp
> index 30923cc..585211a 100644
> --- a/agents/maildispatcher/sendjob.cpp
> +++ b/agents/maildispatcher/sendjob.cpp
> @@ -327,8 +327,21 @@ void SendJob::Private::postJobResult( KJob *job )
> 
> if ( job->error() ) {
> kDebug() << "Error deleting or moving to sent-mail.";
> +
> +    const SentBehaviourAttribute *attribute = \
> item.attribute<SentBehaviourAttribute>(); +    Q_ASSERT( attribute );
> +
> +    QString errorString;
> +    switch( attribute->sentBehaviour() ) {
> +    case SentBehaviourAttribute::Delete:
> +      errorString = i18n( "but failed to remove the message from the outbox" );
> +      break;
> +    default:
> +      errorString = i18n( "but failed to move the message to the sent-mail folder" \
> ); +      break;
> +    }
> q->setError( UserDefinedError );
> -    q->setErrorText( i18n( "Sending succeeded, but failed to finalize message." ) \
> + ' ' + job->errorString() ); +    q->setErrorText( i18n( "Sending succeeded, %1.", \
> errorString ) + ' ' + job->errorString() ); storeResult( false, q->errorString() );
> } else {
> kDebug() << "Success deleting or moving to sent-mail.";
> 


[prev in list] [next in list] [prev in thread] [next in thread]