[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-i18n-doc
Subject:    Re: String change in kdelibs/kdeui
From:       Vít Pelčák <vit () pelcak ! org>
Date:       2010-11-29 12:05:32
Message-ID: AANLkTimx3LjVROEPTztc2yViPFKRcY6EqfZnU748GQYK () mail ! gmail ! com
[Download RAW message or body]

Which po file is affected, please?

Otherwise if only this sentence is changed, I'm OK with that.

Czech team.

2010/11/29 Teo Mrnjavac <teo@kde.org>:
> Hello translators,
> I have a string change that I forgot to do before string freeze. It's
> an addition of a few strings, but those strings are very similar to
> existing ones. It's needed because "Visit contributor's profile on
> blog" isn't really a meaningful sentence, and "Visit contributor's
> blog" is.
> Here it goes:
>
> 2ad2c2480595f8be7455bf3c9a937c402d1597bd
>  .../kaboutapplicationpersonlistdelegate_p.cpp      |   28 +++++++++++++++-----
>  1 files changed, 21 insertions(+), 7 deletions(-)
>
> diff --git a/kdeui/dialogs/kaboutapplicationpersonlistdelegate_p.cpp
> b/kdeui/dialogs/kaboutapplicationpersonlistdelegate_p.cpp
> index 39bc08d..50ea998 100644
> --- a/kdeui/dialogs/kaboutapplicationpersonlistdelegate_p.cpp
> +++ b/kdeui/dialogs/kaboutapplicationpersonlistdelegate_p.cpp
> @@ -57,12 +57,12 @@ QList< QWidget *>
> KAboutApplicationPersonListDelegate::createItemWidgets() const
>     KToolBar *mainLinks = new KToolBar( itemView(), false, false );
>
>     KAction *emailAction = new KAction( KIcon( "internet-mail" ),
> -                                        i18n("Email contributor"),
> +                                        i18n( "Email contributor" ),
>                                         mainLinks );
>     emailAction->setVisible( false );
>     mainLinks->addAction( emailAction );
>     KAction *homepageAction = new KAction( KIcon( "applications-internet" ),
> -                                           i18n("Visit contributor's
> homepage"),
> +                                           i18n( "Visit contributor's
> homepage" ),
>                                            mainLinks );
>     homepageAction->setVisible( false );
>     mainLinks->addAction( homepageAction );
> @@ -122,12 +122,12 @@ void
> KAboutApplicationPersonListDelegate::updateItemWidgets( const
> QList<QWidget
>     mainLinks->setSizePolicy( QSizePolicy::Fixed, QSizePolicy::Fixed );
>     KAction *action;
>     action = qobject_cast< KAction * >( mainLinks->actions().at(
> EmailAction ) );
> -    action->setToolTip( profile.email() );
> +    action->setToolTip( i18nc( "Action to send an email to a
> contributor" , "Email contributor\n%1", profile.email() ) );
>     action->setData( QString( QLatin1String( "mailto:") + profile.email() ) );
>     action->setVisible( true );
>     if( !profile.homepage().isEmpty() ) {
>         action = qobject_cast< KAction * >( mainLinks->actions().at(
> HomepageAction ) );
> -        action->setToolTip( profile.homepage().url() );
> +        action->setToolTip( i18n( "Visit contributor's homepage\n%1",
> profile.homepage().url() ) );
>         action->setData( profile.homepage().url() );
>         action->setVisible( true );
>     }
> @@ -155,9 +155,23 @@ void
> KAboutApplicationPersonListDelegate::updateItemWidgets( const
> QList<QWidget
>             continue;   //We skip it if it's the same as the homepage
> from KAboutData
>
>         action = qobject_cast< KAction * >(
> socialLinks->actions().at( currentSocialLinkAction ) );
> -        action->setToolTip( i18n( "Visit contributor's profile on %1\n%2",
> -                                  link.prettyType(),
> -                                  link.url().url() ) );
> +        if( link.type() == KAboutApplicationPersonProfileOcsLink::Other ) {
> +            action->setToolTip( i18n( "Visit contributor's page\n%1",
> +                                      link.url().url() ) );
> +        }
> +        else if( link.type() == KAboutApplicationPersonProfileOcsLink::Blog ) {
> +            action->setToolTip( i18n( "Visit contributor's blog\n%1",
> +                                      link.url().url() ) );
> +        }
> +        else if( link.type() ==
> KAboutApplicationPersonProfileOcsLink::Homepage ) {
> +            action->setToolTip( i18n( "Visit contributor's homepage\n%1",
> +                                      link.url().url() ) );
> +        }
> +        else {
> +            action->setToolTip( i18n( "Visit contributor's profile on %1\n%2",
> +                                      link.prettyType(),
> +                                      link.url().url() ) );
> +        }
>         action->setIcon( link.icon() );
>         action->setData( link.url().url() );
>         action->setVisible( true );
>
> Please let me know if it's ok to commit it.
> Best regards,
> --
> Teo Mrnjavac
>



-- 
Vit Pelcak

[prev in list] [next in list] [prev in thread] [next in thread]