From kde-i18n-doc  Sun Oct 26 18:39:03 2008
From: "doutor.zero" <doutor.zero () gmail ! com>
Date: Sun, 26 Oct 2008 18:39:03 +0000
To: kde-i18n-doc
Subject: Re: extragear/multimedia/amarok/src
Message-Id: <4904B947.7070304 () gmail ! com>
X-MARC-Message: https://marc.info/?l=kde-i18n-doc&m=122504643203267

Hi,

Please, can you explain better the meaning of this string below?

Imported <b>%1 - %2 (%3)</b>

What is imported (the meaning of %1, %2 and %3), covers, albums or what? 
Is important to know that to do a precise translation to portuguese.

Thank you.


Seb Ruiz escreveu:
> SVN commit 876028 by seb:
>
> Better strings for translations, and show a message when importing cover art, as this could be a lengthy process. Sorry for yet another hassle, translators. A million thanks.
> CCMAIL: kde-i18n-doc@kde.org
>
>
>  M  +3 -0      databaseimporter/amarok14/FastForwardWorker.cpp  
>  M  +1 -0      databaseimporter/amarok14/FastForwardWorker.h  
>  M  +5 -1      dialogs/DatabaseImporterDialog.cpp  
>
>
> --- trunk/extragear/multimedia/amarok/src/databaseimporter/amarok14/FastForwardWorker.cpp #876027:876028
> @@ -152,6 +152,9 @@
>  
>      if( m_importArtwork )
>      {
> +        QString message = i18n( "Importing downloaded album art" );
> +        emit sendMessage( message );
> +
>          // FIXME: determining the old cover art directory is a major hack, I admit.
>          // What's the best way of doing this?
>          QString newCoverPath = Amarok::saveLocation( "albumcovers/large/" );
> --- trunk/extragear/multimedia/amarok/src/databaseimporter/amarok14/FastForwardWorker.h #876027:876028
> @@ -46,6 +46,7 @@
>  
>      signals:
>          void importError( QString ); 
> +        void sendMessage( QString );
>          void trackAdded( Meta::TrackPtr );
>  
>      private:
> --- trunk/extragear/multimedia/amarok/src/dialogs/DatabaseImporterDialog.cpp #876027:876028
> @@ -174,7 +174,11 @@
>  {
>      if( !track ) return;
>  
> -    QString text = i18n( "Imported <b>%1 - %2 (%3)</b>", track->artist()->name(), track->name(), track->album()->name() );
> +    QString text;
> +    if( !track->album() || track->album()->name().isEmpty() )
> +        text = i18n( "Imported <b>%1 - %2</b>", track->artist()->name(), track->name() );
> +    else
> +        text = i18n( "Imported <b>%1 - %2 (%3)</b>", track->artist()->name(), track->name(), track->album()->name() );
>      m_results->appendHtml( text );
>  }
>  
>
>