From kde-i18n-doc Thu Aug 21 20:47:03 2008 From: Albert Astals Cid Date: Thu, 21 Aug 2008 20:47:03 +0000 To: kde-i18n-doc Subject: Re: kcmlilo: strings marked for translation, but shouldn't be (?) Message-Id: <200808212247.04465.aacid () kde ! org> X-MARC-Message: https://marc.info/?l=kde-i18n-doc&m=121935169121594 A Dimecres 20 Agost 2008, Marta Rybczynska va escriure: > Hello, > There's a problem in kcmlilo (reported for early 3.1 here: > https://bugs.kde.org/show_bug.cgi?id=57677, > but still with us). Graphics modes are marked for translation > (kdeadmin/lilo-config/kde-qt-common/general.cpp lines 105 up to 130). > There are conditions later (the same file, lines 167 to 178) that > compare with literal (untranslated) values line "default" or > search part of the string. > > This code can likely break lilo.conf. > > I vote to remove all _() from lines 105 to 130. Later fix may be to > re-write this part to use indices etc instead of names. > > Please someone check if my analysis is correct. Agree with you, better untranslated than broken. Commited to both stable and trunk branches. Thanks, Albert > > Regards, > Marta Rybczyńska > Polish team