[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-i18n-doc
Subject:    Re: branches/stable/extragear/multimedia/amarok/src
From:       Jeff Mitchell <kde-dev () emailgoeshere ! com>
Date:       2007-05-31 12:34:58
Message-ID: 465EC0F2.30402 () emailgoeshere ! com
[Download RAW message or body]

While you guys are at it, *please* change instances of "amaroK" and 
"AmaroK" to "Amarok" in the various desktop files.  I sent an email a 
while ago notifying about a string change in the .desktop file and 
asking for the Amarok capitalization to be fixed, and in many cases the 
new string was translated but the capitalization was left alone.

Thanks,
Jeff

Seb Ruiz wrote:
> SVN commit 670063 by seb:
> 
> Last.fm has changed the way we can listen to artist radios due to licensing. This \
> means that we can't listen to the radio station from multiple artists. Only one \
> artist from now on... 
> Sorry for the string breakage, but it is a critical fix.
> CCMAIL: kde-i18n-doc@kde.org
> 
> BUG: 146020
> 
> 
> M  +4 -5      lastfm.cpp  
> M  +2 -2      playlistwindow.cpp  
> 
> 
> --- branches/stable/extragear/multimedia/amarok/src/lastfm.cpp #670062:670063
> @@ -222,10 +222,9 @@
> QString token;
> CustomStationDialog dialog( 0 );
> 
> -    if( dialog.exec() == QDialog::Accepted ) {
> -        const QStringList artists = QStringList::split( ",", dialog.text() );
> -        for( uint i = 0; i < artists.count(); i++ )
> -            token += ( i > 0 ? "," : "" ) + artists[i].simplifyWhiteSpace();
> +    if( dialog.exec() == QDialog::Accepted )
> +    {
> +        token =  dialog.text();
> }
> 
> return token;
> @@ -1080,7 +1079,7 @@
> {
> makeVBoxMainWidget();
> 
> -    new QLabel( i18n( "Enter the name of a band or artist you like:\n(You can \
> enter multiple artists separated by commas)" ), mainWidget() ); +    new QLabel( \
> i18n( "Enter the name of a band or artist you like:" ), mainWidget() ); 
> m_edit = new KLineEdit( mainWidget(), "CustomStationEdit" );
> m_edit->setFocus();
> --- branches/stable/extragear/multimedia/amarok/src/playlistwindow.cpp \
> #670062:670063 @@ -949,7 +949,7 @@
> const QString token = LastFm::Controller::createCustomStation();
> if( token.isEmpty() ) return;
> 
> -    const KURL url( "lastfm://artistnames/" + token );
> +    const KURL url( "lastfm://artist/" + token + "/similarartists" );
> Playlist::instance()->insertMedia( url, Playlist::Append|Playlist::DirectPlay );
> }
> 
> @@ -959,7 +959,7 @@
> const QString token = LastFm::Controller::createCustomStation();
> if( token.isEmpty() ) return;
> 
> -    const KURL url( "lastfm://artistnames/" + token );
> +    const KURL url( "lastfm://artist/" + token + "/similarartists" );
> Playlist::instance()->insertMedia( url );
> }
> 
> 


[prev in list] [next in list] [prev in thread] [next in thread]