[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-i18n-doc
Subject:    Re: koffice/karbon
From:       Tom Albers <tomalbers () kde ! nl>
Date:       2006-03-15 20:49:51
Message-ID: 200603152049.k2FKnq76006239 () smtp30 ! hccnet ! nl
[Download RAW message or body]

Hi,

Thanks for the fixes, I just have a couple more:

Jan Hambrecht wrote:
> +             QString selectMessage = QString( i18n( "Selection [(%1, %2), (%3, %4)]
> (%5)") ).arg( KoUnit::toUserValue( rect.x(), view()->part()->unit() ), 0,
> 'f', 1 ).arg( KoUnit::toUserValue( rect.y(), view()->part()->unit() ), 0,
> 'f', 1 ).arg( KoUnit::toUserValue( rect.right(), view()->part()->unit() ),
> 0, 'f', 1 ).arg( KoUnit::toUserValue( rect.bottom(),
> view()->part()->unit() ), 0, 'f', 1 ).arg( view()->part()->unitName() );

The translators only see "Selection [(%1, %2), (%3, %4)]  (%5)", so it is
impossible to determine if the order should be different (think ltr
languages). Please be generous with comments....


>  if( selection.objects().count() == 1 )
>  VVisitor::visitVSelection( selection );
>  else
> -             m_desc = i18n( QString( "%1 objects" ).arg( selection.objects().count()
> ).latin1() );
> +             m_desc = i18n( "%1 objects" ).arg( selection.objects().count() );
>  }

Although english only has 'one' and 'more than one' as plural, some
languages have a lot more, so in this case it should still be:
 i18n( "One object", "%n Objects", selection.objects().count() );
to allow those languages to use correct plural form in all cases.
  
> +     m_desc = i18n( "1 group, containing %1 objects" ).arg(
> group.objects().count() );

Idem.

Tom Albers

[prev in list] [next in list] [prev in thread] [next in thread]