[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-i18n-doc
Subject:    New string in Kalzium
From:       Philip Rodrigues <philip.rodrigues () chch ! ox ! ac ! uk>
Date:       2005-12-29 15:53:04
Message-ID: dp10ni$gan$1 () sea ! gmane ! org
[Download RAW message or body]

Hi,
Carsten Niehaus asked me to forward this message on, as he's having trouble
with mail at the moment. Would it be OK to add the string "Invalid input"
to Kalzium to fix a bug? Full description follows:

In Kalzium you can calculate the molecular weight of a molecule.

Calculate "CO2Of". Of course there is no element "f". The result is (on the
shell)

kalzium: Found element C
kalzium: Found element O
kalzium: Weight of term = 12.0107
kalzium: [Element* MoleculeParser::lookupElement(const QString&)] no such
element: Of
kalzium: Weight of term = 31.9988
kalzium: Mass of CO2Of = 44.0095

The GUI presents 44.0095 as the result to the user. No errormessage. This is
wrong for two reasons:
1 - As the input was invalid there should be no result
2 - *If* we show a result it be neglect the "f" and display "60.0089" as a
result because the would be correct for "CO2O".


Now calculate "CO2O":

kalzium: Found element C
kalzium: Found element O
kalzium: Weight of term = 12.0107
kalzium: Found element O
kalzium: Weight of term = 31.9988
kalzium: Weight of term = 15.9994
kalzium: Mass of CO2O = 60.0089

The result is correct and presented as 60.0089.

Solution: Display a "Invalid input"-error.

Question (for the kde-i18n-folks): Would it be ok to display the new
errormessage? I would introduce the new string today. I already added the 
patch to the bug, see http://bugs.kde.org/show_bug.cgi?id=117774#c8

Carsten
-- 
KDE Documentation Team: http://i18n.kde.org/doc
KDE Documentation Online: http://docs.kde.org

[prev in list] [next in list] [prev in thread] [next in thread]