[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-i18n-doc
Subject:    Fwd: using an untranslated string?
From:       Anders Lund <anders () alweb ! dk>
Date:       2005-10-31 18:10:43
Message-ID: 200510311910.44629.anders () alweb ! dk
[Download RAW message or body]

Hi,

Do you have any comments to the issue described in the below message?

Otherwise I'll commit this tommorow (tuesday night, CET).

Please CC any comments, as I'm not subscribed to this list.

-anders

----------  Forwarded Message  ----------

Subject: using an untranslated string?
Date: Sunday 30 October 2005 21:02
From: Anders Lund <anders@alweb.dk>
To: kwrite-devel@kde.org

Hi,

the attached patch adresses bug 114121
(http://bugs.kde.org/show_bug.cgi?id=114121) which is problem that hangs and
potentially crashes kate.

The patch contains an untranslated string, because i feel that it is wrong to
abort a user initiated action with no explanation. So my question is, is it
OK to commit this way, or should I rather remove the string and not explain
why things went wrong?

-anders

--
www: http://alweb.dk
jabber: anderslund@jabber.dk

-------------------------------------------------------

-- 
www: http://alweb.dk
jabber: anderslund@jabber.dk

["katecmds.diff" (text/x-diff)]

Index: katecmds.cpp
===================================================================
--- katecmds.cpp	(revision 471065)
+++ katecmds.cpp	(working copy)
@@ -373,6 +373,7 @@
   // * the existing insertion is fine, including the line calculation.
 
   QStringList patterns = QStringList::split( QRegExp("(^\\\\n|(?![^\\\\])\\\\n)"), find, true );
+
   if ( patterns.count() > 1 )
   {
     for ( uint i = 0; i < patterns.count(); i++ )
@@ -488,6 +489,13 @@
   exchangeAbbrevs(replace);
    kdDebug(13025)<< "SedReplace: replace=" << replace.latin1() <<endl;
 
+   if ( find.contains("\\n") )
+   {
+     // FIXME i18n this message (or make it work)
+     msg = "Sorry, but we can't replace newlines (yet)";
+     return false;
+   }
+
   KateDocument *doc = ((KateView*)view)->doc();
   if ( ! doc ) return false;
 


[prev in list] [next in list] [prev in thread] [next in thread]