[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-i18n-doc
Subject:    typos in KStars
From:       Jason Harris <kstars () 30doradus ! org>
Date:       2005-10-24 16:55:16
Message-ID: 200510240955.16473.kstars () 30doradus ! org
[Download RAW message or body]

Hello,

Bug report #114927 (http://bugs.kde.org/show_bug.cgi?id=114927) points out 
some unfortunate typos in some (potentially) user-visible strings.  In short, 
I am using arg() to fill in three values in an i18n() string, but I 
mistakenly use "%1", "%2", "%1" as the three placeholders.

The bug reporter suggests this is worth breaking strings freeze to fix.  
However, I'd like to note that the affected lines appear in a function that 
will only be called if the user adds their own custom object catalog (and 
furthermore, only if there is an error parsing the catalog).  This is 
probably going to be a very small number of users.

With that caveat in mind, is it worth committing the change now, or should I 
wait until after 3.5.0 ?

The patch is attached.

thanks,
Jason 
-- 
-------------------------------
KStars: KDE Desktop Planetarium
http://edu.kde.org/kstars

["kstarsdata.patch" (text/x-diff)]

Index: kstarsdata.cpp
===================================================================
--- kstarsdata.cpp	(revision 473761)
+++ kstarsdata.cpp	(working copy)
@@ -1280,7 +1280,7 @@
 		if ( Columns[i] == "Dc" ) {
 			if ( ! Dec.setFromString( d[i], true ) ) {
 				if ( showerrs )
-					errs.append( i18n( "Line %1, field %2: Unable to parse Dec value: %1" )
+					errs.append( i18n( "Line %1, field %2: Unable to parse Dec value: %3" )
 							.arg(lnum).arg(i).arg(d[i]) );
 				return false;
 			}
@@ -1292,14 +1292,14 @@
 			if ( ok ) {
 				if ( iType == 2 || iType > 8 ) {
 					if ( showerrs )
-						errs.append( i18n( "Line %1, field %2: Invalid object type: %1" )
+						errs.append( i18n( "Line %1, field %2: Invalid object type: %3" )
 								.arg(lnum).arg(i).arg(d[i]) +
 								i18n( "Must be one of 0, 1, 3, 4, 5, 6, 7, 8." ) );
 					return false;
 				}
 			} else {
 				if ( showerrs )
-					errs.append( i18n( "Line %1, field %2: Unable to parse Object type: %1" )
+					errs.append( i18n( "Line %1, field %2: Unable to parse Object type: %3" )
 							.arg(lnum).arg(i).arg(d[i]) );
 				return false;
 			}
@@ -1310,7 +1310,7 @@
 			mag = d[i].toFloat( &ok );
 			if ( ! ok ) {
 				if ( showerrs )
-					errs.append( i18n( "Line %1, field %2: Unable to parse Magnitude: %1" )
+					errs.append( i18n( "Line %1, field %2: Unable to parse Magnitude: %3" )
 							.arg(lnum).arg(i).arg(d[i]) );
 				return false;
 			}
@@ -1321,7 +1321,7 @@
 			a = d[i].toFloat( &ok );
 			if ( ! ok ) {
 				if ( showerrs )
-					errs.append( i18n( "Line %1, field %2: Unable to parse Major Axis: %1" )
+					errs.append( i18n( "Line %1, field %2: Unable to parse Major Axis: %3" )
 							.arg(lnum).arg(i).arg(d[i]) );
 				return false;
 			}
@@ -1332,7 +1332,7 @@
 			b = d[i].toFloat( &ok );
 			if ( ! ok ) {
 				if ( showerrs )
-					errs.append( i18n( "Line %1, field %2: Unable to parse Minor Axis: %1" )
+					errs.append( i18n( "Line %1, field %2: Unable to parse Minor Axis: %3" )
 							.arg(lnum).arg(i).arg(d[i]) );
 				return false;
 			}
@@ -1343,7 +1343,7 @@
 			PA = d[i].toFloat( &ok );
 			if ( ! ok ) {
 				if ( showerrs )
-					errs.append( i18n( "Line %1, field %2: Unable to parse Position Angle: %1" )
+					errs.append( i18n( "Line %1, field %2: Unable to parse Position Angle: %3" )
 							.arg(lnum).arg(i).arg(d[i]) );
 				return false;
 			}


[prev in list] [next in list] [prev in thread] [next in thread]