--===============1272990929761753965== Content-Type: multipart/alternative; boundary="===============1446914375120754480==" --===============1446914375120754480== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit > On oct. 18, 2014, 1:03 a.m., Friedrich W. H. Kossebau wrote: > > Actually Solid curently also fails on build.kde.org with the same error: http://build.kde.org/view/Frameworks/job/solid_master_qt5/118/consoleText Solid build is green now so I guess this is no longer needed. If I am mistaken feel free to re-open the review and add Lukas to it! Thanks! - Àlex ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120635/#review68640 ----------------------------------------------------------- On jul. 11, 2015, 8:40 p.m., Friedrich W. H. Kossebau wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/120635/ > ----------------------------------------------------------- > > (Updated jul. 11, 2015, 8:40 p.m.) > > > Review request for Solid and Àlex Fiestas. > > > Repository: solid > > > Description > ------- > > Build fails for me with > ``` > [ 96%] Building CXX object autotests/CMakeFiles/logindinhibitionargument.dir/logindinhibitionargumenttest.cpp.o > In file included from /home/koder/Kode/kdegit/kf5/frameworks/solid/autotests/logindinhibitionargumenttest.cpp:22:0: > /home/koder/Kode/kdegit/kf5/frameworks/solid/autotests/../src/solid/power/backends/freedesktop/logindinhibitionargument.h:25:25: fatal error: solid/power.h: Datei oder Verzeichnis nicht gefunden > #include "solid/power.h" > ^ > compilation terminated. > make[2]: *** [autotests/CMakeFiles/logindinhibitionargument.dir/logindinhibitionargumenttest.cpp.o] Fehler 1 > make[1]: *** [autotests/CMakeFiles/logindinhibitionargument.dir/all] Fehler 2 > make: *** [all] Fehler 2 > ``` > > Actually I am puzzled how all the `"solid/power.h"` or `` includes are resolved on the very first build of Solid (when nothing has been installed yet). I could not find any such path in the source dirs or the build dirs. Is there some cmake magic which injects those path in a virtual way during the build? > > In any case, that seems to be missing when building the test "logindinhibitionargument", so that include there cannot be resolved. This patch is just a workaround to make things building for those where "power/backends/freedesktop" would not be built anyway, even if that class does not have any external includes that have the same deps of that backend. > > You might have a better idea what the real fix would be. > > > Diffs > ----- > > autotests/CMakeLists.txt 621665c > > Diff: https://git.reviewboard.kde.org/r/120635/diff/ > > > Testing > ------- > > > Thanks, > > Friedrich W. H. Kossebau > > --===============1446914375120754480== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 8bit

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120635/

On octubre 18th, 2014, 1:03 a.m. UTC, Friedrich W. H. Kossebau wrote:
Actually Solid curently also fails on build.kde.org with the same error: http://build.kde.org/view/Frameworks/job/solid_master_qt5/118/consoleText

Solid build is green now so I guess this is no longer needed.

If I am mistaken feel free to re-open the review and add Lukas to it! Thanks!

- Àlex

On juliol 11th, 2015, 8:40 p.m. UTC, Friedrich W. H. Kossebau wrote:

Review request for Solid and Àlex Fiestas.

By Friedrich W. H. Kossebau.

Updated jul. 11, 2015, 8:40 p.m.

Repository: solid

Description

Build fails for me with

[ 96%] Building CXX object autotests/CMakeFiles/logindinhibitionargument.dir/logindinhibitionargumenttest.cpp.o
In file included from /home/koder/Kode/kdegit/kf5/frameworks/solid/autotests/logindinhibitionargumenttest.cpp:22:0:
/home/koder/Kode/kdegit/kf5/frameworks/solid/autotests/../src/solid/power/backends/freedesktop/logindinhibitionargument.h:25:25: fatal error: solid/power.h: Datei oder Verzeichnis nicht gefunden
 #include "solid/power.h"
                         ^
compilation terminated.
make[2]: *** [autotests/CMakeFiles/logindinhibitionargument.dir/logindinhibitionargumenttest.cpp.o] Fehler 1
make[1]: *** [autotests/CMakeFiles/logindinhibitionargument.dir/all] Fehler 2
make: *** [all] Fehler 2

Actually I am puzzled how all the "solid/power.h" or <solid/job.h> includes are resolved on the very first build of Solid (when nothing has been installed yet). I could not find any such path in the source dirs or the build dirs. Is there some cmake magic which injects those path in a virtual way during the build?

In any case, that seems to be missing when building the test "logindinhibitionargument", so that include there cannot be resolved. This patch is just a workaround to make things building for those where "power/backends/freedesktop" would not be built anyway, even if that class does not have any external includes that have the same deps of that backend.

You might have a better idea what the real fix would be.

Diffs

autotests/CMakeLists.txt (621665c)

--===============1446914375120754480==-- --===============1272990929761753965== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KS2RlLWhhcmR3 YXJlLWRldmVsIG1haWxpbmcgbGlzdApLZGUtaGFyZHdhcmUtZGV2ZWxAa2RlLm9yZwpodHRwczov L21haWwua2RlLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2tkZS1oYXJkd2FyZS1kZXZlbAo= --===============1272990929761753965==--