[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-hardware-devel
Subject: [Kde-hardware-devel] Review Request 120635: Only build test logindinhibitionargument with WITH_NEW_P
From: "Friedrich W. H. Kossebau" <kossebau () kde ! org>
Date: 2014-10-18 0:44:18
Message-ID: 20141018004418.21224.12749 () probe ! kde ! org
[Download RAW message or body]
--===============3364346320922943566==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120635/
-----------------------------------------------------------
Review request for Solid and Àlex Fiestas.
Repository: solid
Description
-------
Build fails for me with
```
[ 96%] Building CXX object \
autotests/CMakeFiles/logindinhibitionargument.dir/logindinhibitionargumenttest.cpp.o \
In file included from \
/home/koder/Kode/kdegit/kf5/frameworks/solid/autotests/logindinhibitionargumenttest.cpp:22:0:
/home/koder/Kode/kdegit/kf5/frameworks/solid/autotests/../src/solid/power/backends/freedesktop/logindinhibitionargument.h:25:25: \
fatal error: solid/power.h: Datei oder Verzeichnis nicht gefunden #include \
"solid/power.h" ^
compilation terminated.
make[2]: *** [autotests/CMakeFiles/logindinhibitionargument.dir/logindinhibitionargumenttest.cpp.o] \
Fehler 1 make[1]: *** [autotests/CMakeFiles/logindinhibitionargument.dir/all] Fehler \
2
make: *** [all] Fehler 2
```
Actually I am puzzled how all the `"solid/power.h"` or `<solid/job.h>` includes are \
resolved on the very first build of Solid (when nothing has been installed yet). I \
could not find any such path in the source dirs or the build dirs. Is there some \
cmake magic which injects those path in a virtual way during the build?
In any case, that seems to be missing when building the test \
"logindinhibitionargument", so that include there cannot be resolved. This patch is \
just a workaround to make things building for those where \
"power/backends/freedesktop" would not be built anyway, even if that class does not \
have any external includes that have the same deps of that backend.
You might have a better idea what the real fix would be.
Diffs
-----
autotests/CMakeLists.txt 621665c
Diff: https://git.reviewboard.kde.org/r/120635/diff/
Testing
-------
Thanks,
Friedrich W. H. Kossebau
--===============3364346320922943566==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/120635/">https://git.reviewboard.kde.org/r/120635/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Solid and Àlex Fiestas.</div>
<div>By Friedrich W. H. Kossebau.</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
solid
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Build fails for me with</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;"><div \
class="codehilite" style="background: #f8f8f8"><pre style="line-height: 125%">[ <span \
style="color: #666666">96%</span>] Building CXX object autotests<span style="color: \
#666666">/</span>CMakeFiles<span style="color: \
#666666">/</span>logindinhibitionargument.dir<span style="color: \
#666666">/</span>logindinhibitionargumenttest.cpp.o In file included from <span \
style="color: #666666">/</span>home<span style="color: #666666">/</span>koder<span \
style="color: #666666">/</span>Kode<span style="color: #666666">/</span>kdegit<span \
style="color: #666666">/</span>kf5<span style="color: \
#666666">/</span>frameworks<span style="color: #666666">/</span>solid<span \
style="color: #666666">/</span>autotests<span style="color: \
#666666">/</span>logindinhibitionargumenttest.cpp<span style="color: \
#666666">:22:0:</span> <span style="color: #666666">/</span>home<span style="color: \
#666666">/</span>koder<span style="color: #666666">/</span>Kode<span style="color: \
#666666">/</span>kdegit<span style="color: #666666">/</span>kf5<span style="color: \
#666666">/</span>frameworks<span style="color: #666666">/</span>solid<span \
style="color: #666666">/</span>autotests<span style="color: #666666">/</span>..<span \
style="color: #666666">/</span>src<span style="color: #666666">/</span>solid<span \
style="color: #666666">/</span>power<span style="color: \
#666666">/</span>backends<span style="color: #666666">/</span>freedesktop<span \
style="color: #666666">/</span>logindinhibitionargument.h<span style="color: \
#666666">:25:25:</span> fatal error<span style="color: #666666">:</span> solid<span \
style="color: #666666">/</span>power.h<span style="color: #666666">:</span> Datei \
oder Verzeichnis nicht gefunden <span style="border: 1px solid \
#FF0000">#</span>include <span style="color: \
#BA2121">"solid/power.h"</span> <span style="color: #666666">^</span>
compilation terminated.
make[<span style="color: #666666">2</span>]<span style="color: #666666">:</span> \
<span style="color: #666666">***</span> [autotests<span style="color: \
#666666">/</span>CMakeFiles<span style="color: \
#666666">/</span>logindinhibitionargument.dir<span style="color: \
#666666">/</span>logindinhibitionargumenttest.cpp.o] Fehler <span style="color: \
#666666">1</span> make[<span style="color: #666666">1</span>]<span style="color: \
#666666">:</span> <span style="color: #666666">***</span> [autotests<span \
style="color: #666666">/</span>CMakeFiles<span style="color: \
#666666">/</span>logindinhibitionargument.dir<span style="color: \
#666666">/</span>all] Fehler <span style="color: #666666">2</span> <span \
style="color: #A0A000">make:</span> <span style="color: #666666">***</span> [all] \
Fehler <span style="color: #666666">2</span> </pre></div>
</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Actually I am puzzled how all the <code \
style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: \
0;line-height: inherit;">"solid/power.h"</code> or <code style="text-rendering: \
inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: \
inherit;"><solid/job.h></code> includes are resolved on the very first build of \
Solid (when nothing has been installed yet). I could not find any such path in the \
source dirs or the build dirs. Is there some cmake magic which injects those path in \
a virtual way during the build?</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">In any case, that seems \
to be missing when building the test "logindinhibitionargument", so that include \
there cannot be resolved. This patch is just a workaround to make things building for \
those where "power/backends/freedesktop" would not be built anyway, even if that \
class does not have any external includes that have the same deps of that \
backend.</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">You might have a better idea what the real fix would \
be.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>autotests/CMakeLists.txt <span style="color: grey">(621665c)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/120635/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============3364346320922943566==--
_______________________________________________
Kde-hardware-devel mailing list
Kde-hardware-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-hardware-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic