[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-hardware-devel
Subject: Re: [Kde-hardware-devel] Review Request 119822: QScreen backend for libkscreen
From: "Ben Cooksley" <bcooksley () kde ! org>
Date: 2014-08-19 8:00:10
Message-ID: 20140819080010.26013.18444 () probe ! kde ! org
[Download RAW message or body]
--===============2278940532407374377==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
> On Aug. 18, 2014, 11:55 a.m., Àlex Fiestas wrote:
> > autotests/testqscreenbackend.cpp, line 66
> > <https://git.reviewboard.kde.org/r/119822/diff/1/?file=306029#file306029line66>
> >
> > If we don't have a config even though we correctly configured the backend, should \
> > not we fail? a QSKIP might be unnoticed (specially in jenkins).
>
> Sebastian Kügler wrote:
> Until we can be sure to have a config running (i.e. either an X or a Wayland \
> server), this would mean we'd have failing tests. I'm happy to remove the SKIP once \
> we have the CI / tooling caught up to bring up a server for us, until then, no use \
> in having it not SKIP.
The CI system already starts an Xvfb server - although this doesn't support xrandr...
Plain X itself can't be run headless from what I understand.
- Ben
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119822/#review64727
-----------------------------------------------------------
On Aug. 18, 2014, 9:31 a.m., Sebastian Kügler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119822/
> -----------------------------------------------------------
>
> (Updated Aug. 18, 2014, 9:31 a.m.)
>
>
> Review request for Plasma and Solid.
>
>
> Repository: libkscreen
>
>
> Description
> -------
>
> This patch adds a QScreen backend to libkscreen.
>
> This is useful to avoid a dependency on XRandR (at build time) and a running X \
> server at runtime.
> The backend itself is read-only and kept simple. It only reports the basic \
> necessities (which is what QScreen provides).
> The changes are kept to the backends/qscreen directory, so no API has been touched. \
> The changes outside of that directory are autotests, tests, and a fallback to the \
> qscreen backend non non-X11 platforms. The latter will automatically make \
> libkscreen work on Wayland (as far as QScreen allows us to, so r-o). This case \
> otherwise just crashes, and the XRandR backend can't work. If the user specifies \
> the backend using the KSCREEN_BACKEND env var, it will be respected, the automatism \
> only triggers when no backend is explicitely specified. I've also added apidocs in \
> some files, but again, no functional changes.
> The plan is to augment this also with a native Wayland backend, which will take a \
> bit longer to complete (more complex, it's r-w, I have to learn Wayland APIs). That \
> backend is work-in-progress in the sebas/wayland branch. The QScreen backend allows \
> us to test and run our code under Wayland, without crashing, so we can continue the \
> port while a native Wayland backend is conceived.
> You can find the code for this QScreen backend in sebas/qscreen if you'd like to \
> give it a try.
>
> Diffs
> -----
>
> autotests/CMakeLists.txt 18b93c0
> autotests/testqscreenbackend.cpp PRE-CREATION
> backends/CMakeLists.txt a827ee8
> backends/abstractbackend.h 7ffe627
> backends/qscreen/CMakeLists.txt PRE-CREATION
> backends/qscreen/qscreenbackend.h PRE-CREATION
> backends/qscreen/qscreenbackend.cpp PRE-CREATION
> backends/qscreen/qscreenconfig.h PRE-CREATION
> backends/qscreen/qscreenconfig.cpp PRE-CREATION
> backends/qscreen/qscreenoutput.h PRE-CREATION
> backends/qscreen/qscreenoutput.cpp PRE-CREATION
> backends/qscreen/qscreenscreen.h PRE-CREATION
> backends/qscreen/qscreenscreen.cpp PRE-CREATION
> src/CMakeLists.txt 4606862
> src/backendloader.cpp d6ccdff
> src/config.h 10a8f1e
> tests/CMakeLists.txt 86efedc
> tests/testplugandplay.cpp PRE-CREATION
> tests/testpnp.h PRE-CREATION
> tests/testpnp.cpp PRE-CREATION
>
> Diff: https://git.reviewboard.kde.org/r/119822/diff/
>
>
> Testing
> -------
>
> * Ran autotest "testqscreenbackend" under X11 and Wayland -- all pass
> * Tested hotplugging (using included testpnp app) under X11
> * Started plasmashell with KSCREEN_BACKEND=QScreen under X11
> * Started kcmshell5 kcm_kscreen
>
> All of these work correctly in my tests, no strange behaviour observed.
>
>
> Thanks,
>
> Sebastian Kügler
>
>
--===============2278940532407374377==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/119822/">https://git.reviewboard.kde.org/r/119822/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On August 18th, 2014, 11:55 a.m. UTC, <b>Àlex \
Fiestas</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/119822/diff/1/?file=306029#file306029line66" \
style="color: black; font-weight: bold; text-decoration: \
underline;">autotests/testqscreenbackend.cpp</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">66</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">QSKIP</span><span class="p">(</span><span class="s">"QScreenbackend \
invalid"</span><span class="p">,</span> <span class="n">SkipAll</span><span \
class="p">);</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">If we \
don't have a config even though we correctly configured the backend, should not we \
fail? a QSKIP might be unnoticed (specially in jenkins).</p></pre> </blockquote>
<p>On August 18th, 2014, 12:16 p.m. UTC, <b>Sebastian Kügler</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Until \
we can be sure to have a config running (i.e. either an X or a Wayland server), this \
would mean we'd have failing tests. I'm happy to remove the SKIP once we have the CI \
/ tooling caught up to bring up a server for us, until then, no use in having it not \
SKIP.</p></pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">The CI system already starts an Xvfb server - although this doesn't support \
xrandr...<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: normal;" /> Plain X itself can't be run headless from what I \
understand.</p></pre> <br />
<p>- Ben</p>
<br />
<p>On August 18th, 2014, 9:31 a.m. UTC, Sebastian Kügler wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma and Solid.</div>
<div>By Sebastian Kügler.</div>
<p style="color: grey;"><i>Updated Aug. 18, 2014, 9:31 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
libkscreen
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This patch adds a QScreen backend to libkscreen.</p> \
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This is useful to avoid a dependency on XRandR (at \
build time) and a running X server at runtime.</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The \
backend itself is read-only and kept simple. It only reports the basic necessities \
(which is what QScreen provides).</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">The changes are kept to \
the backends/qscreen directory, so no API has been touched. The changes outside of \
that directory are autotests, tests, and a fallback to the qscreen backend non \
non-X11 platforms. The latter will automatically make libkscreen work on Wayland (as \
far as QScreen allows us to, so r-o). This case otherwise just crashes, and the \
XRandR backend can't work. If the user specifies the backend using the \
KSCREEN_BACKEND env var, it will be respected, the automatism only triggers when no \
backend is explicitely specified. I've also added apidocs in some files, but again, \
no functional changes.</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">The plan is to augment this also with a \
native Wayland backend, which will take a bit longer to complete (more complex, it's \
r-w, I have to learn Wayland APIs). That backend is work-in-progress in the \
sebas/wayland branch. The QScreen backend allows us to test and run our code under \
Wayland, without crashing, so we can continue the port while a native Wayland backend \
is conceived.</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">You can find the code for this QScreen backend in \
sebas/qscreen if you'd like to give it a try.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><ul style="padding: 0;text-rendering: inherit;margin: 0 0 0 \
1em;line-height: inherit;white-space: normal;"> <li style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: normal;">Ran autotest \
"testqscreenbackend" under X11 and Wayland -- all pass</li> <li style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">Tested \
hotplugging (using included testpnp app) under X11</li> <li style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
normal;">Started plasmashell with KSCREEN_BACKEND=QScreen under X11</li> <li \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
normal;">Started kcmshell5 kcm_kscreen</li> </ul>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">All of these work correctly in my tests, no strange \
behaviour observed.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>autotests/CMakeLists.txt <span style="color: grey">(18b93c0)</span></li>
<li>autotests/testqscreenbackend.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>backends/CMakeLists.txt <span style="color: grey">(a827ee8)</span></li>
<li>backends/abstractbackend.h <span style="color: grey">(7ffe627)</span></li>
<li>backends/qscreen/CMakeLists.txt <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>backends/qscreen/qscreenbackend.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>backends/qscreen/qscreenbackend.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>backends/qscreen/qscreenconfig.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>backends/qscreen/qscreenconfig.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>backends/qscreen/qscreenoutput.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>backends/qscreen/qscreenoutput.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>backends/qscreen/qscreenscreen.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>backends/qscreen/qscreenscreen.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/CMakeLists.txt <span style="color: grey">(4606862)</span></li>
<li>src/backendloader.cpp <span style="color: grey">(d6ccdff)</span></li>
<li>src/config.h <span style="color: grey">(10a8f1e)</span></li>
<li>tests/CMakeLists.txt <span style="color: grey">(86efedc)</span></li>
<li>tests/testplugandplay.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/testpnp.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/testpnp.cpp <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/119822/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============2278940532407374377==--
_______________________________________________
Kde-hardware-devel mailing list
Kde-hardware-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-hardware-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic