[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-hardware-devel
Subject: Re: [Kde-hardware-devel] Review Request 111699: Fixed "no such signal" message in UPowerManager at s
From: "Albert Vaca Cintora" <albertvaka () gmail ! com>
Date: 2013-07-26 11:23:44
Message-ID: 20130726112344.22410.57414 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On July 26, 2013, 12:05 p.m., Lukáš Tinkl wrote:
> > I'm curious why this is needed, after all, your change just uses a different \
> > mechanism to connect the signals
I'm not sure if the current code actually works, but it gives that error in runtime \
so I think it is better to change it anyway.
- Albert
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111699/#review36528
-----------------------------------------------------------
On July 25, 2013, 10:36 p.m., Albert Vaca Cintora wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111699/
> -----------------------------------------------------------
>
> (Updated July 25, 2013, 10:36 p.m.)
>
>
> Review request for Solid and Àlex Fiestas.
>
>
> Description
> -------
>
> The following message was shown when UPowerManager was instantiated (e.g.: when \
> kded4 starts):
> Object::connect: No such signal QDBusAbstractInterface::DeviceAdded(QString) in \
> /home/vaka/kde4/src/kdelibs/solid/solid/backends/upower/upowermanager.cpp:67 \
> Object::connect: No such signal QDBusAbstractInterface::DeviceRemoved(QString) in \
> /home/vaka/kde4/src/kdelibs/solid/solid/backends/upower/upowermanager.cpp:69
> This patch fixes to connection to the mentioned DBus signal (the normal connect \
> construction that was used doesn't work for dbus signals) so this message doesn't \
> appear anymore, and probably fixes the underlying functionality that required this \
> signal to be connected.
>
> Diffs
> -----
>
> solid/solid/backends/upower/upowermanager.cpp bae234b
>
> Diff: http://git.reviewboard.kde.org/r/111699/diff/
>
>
> Testing
> -------
>
> Manual testing.
>
>
> Thanks,
>
> Albert Vaca Cintora
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/111699/">http://git.reviewboard.kde.org/r/111699/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On July 26th, 2013, 12:05 p.m. CEST, <b>Lukáš \
Tinkl</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I'm curious why this is needed, after all, your change just uses a \
different mechanism to connect the signals </pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I'm not sure if the \
current code actually works, but it gives that error in runtime so I think it is \
better to change it anyway.</pre> <br />
<p>- Albert</p>
<br />
<p>On July 25th, 2013, 10:36 p.m. CEST, Albert Vaca Cintora wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Solid and Àlex Fiestas.</div>
<div>By Albert Vaca Cintora.</div>
<p style="color: grey;"><i>Updated July 25, 2013, 10:36 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">The following message was shown when UPowerManager was instantiated \
(e.g.: when kded4 starts):
Object::connect: No such signal QDBusAbstractInterface::DeviceAdded(QString) in \
/home/vaka/kde4/src/kdelibs/solid/solid/backends/upower/upowermanager.cpp:67 \
Object::connect: No such signal QDBusAbstractInterface::DeviceRemoved(QString) in \
/home/vaka/kde4/src/kdelibs/solid/solid/backends/upower/upowermanager.cpp:69
This patch fixes to connection to the mentioned DBus signal (the normal connect \
construction that was used doesn't work for dbus signals) so this message \
doesn't appear anymore, and probably fixes the underlying functionality that \
required this signal to be connected.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Manual testing.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>solid/solid/backends/upower/upowermanager.cpp <span style="color: \
grey">(bae234b)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/111699/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Kde-hardware-devel mailing list
Kde-hardware-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-hardware-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic