'[Kde-hardware-devel] Review Request 111699: Fixed "no such signal" message in UPowerManager at start'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-hardware-devel
Subject:    [Kde-hardware-devel] Review Request 111699: Fixed "no such signal" message in UPowerManager at start
From:       "Albert Vaca Cintora" <albertvaka () gmail ! com>
Date:       2013-07-25 20:36:34
Message-ID: 20130725203634.28855.36065 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111699/
-----------------------------------------------------------

Review request for Solid and Àlex Fiestas.

Description
-------

The following message was shown when UPowerManager was instantiated (e.g.: when kded4 \
starts):

Object::connect: No such signal QDBusAbstractInterface::DeviceAdded(QString) in \
/home/vaka/kde4/src/kdelibs/solid/solid/backends/upower/upowermanager.cpp:67 \
Object::connect: No such signal QDBusAbstractInterface::DeviceRemoved(QString) in \
/home/vaka/kde4/src/kdelibs/solid/solid/backends/upower/upowermanager.cpp:69

This patch fixes to connection to the mentioned DBus signal (the normal connect \
construction that was used doesn't work for dbus signals) so this message doesn't \
appear anymore, and probably fixes the underlying functionality that required this \
signal to be connected.

Diffs
-----

  solid/solid/backends/upower/upowermanager.cpp bae234b 

Diff: http://git.reviewboard.kde.org/r/111699/diff/

Testing
-------

Manual testing.

Thanks,

Albert Vaca Cintora

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/111699/">http://git.reviewboard.kde.org/r/111699/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Solid and Àlex Fiestas.</div>
<div>By Albert Vaca Cintora.</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">The following message was shown when UPowerManager was instantiated \
(e.g.: when kded4 starts):

Object::connect: No such signal QDBusAbstractInterface::DeviceAdded(QString) in \
/home/vaka/kde4/src/kdelibs/solid/solid/backends/upower/upowermanager.cpp:67 \
Object::connect: No such signal QDBusAbstractInterface::DeviceRemoved(QString) in \
/home/vaka/kde4/src/kdelibs/solid/solid/backends/upower/upowermanager.cpp:69

This patch fixes to connection to the mentioned DBus signal (the normal connect \
construction that was used doesn&#39;t work for dbus signals) so this message \
doesn&#39;t appear anymore, and probably fixes the underlying functionality that \
required this signal to be connected.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Manual testing.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>solid/solid/backends/upower/upowermanager.cpp <span style="color: \
grey">(bae234b)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/111699/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Kde-hardware-devel mailing list
Kde-hardware-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-hardware-devel

[prev in list] [next in list] [prev in thread] [next in thread] 