[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-hardware-devel
Subject: Re: [Kde-hardware-devel] Review Request 110433: bluedevil-wizard: Make it possible to select devices
From: "Commit Hook" <null () kde ! org>
Date: 2013-06-05 12:44:04
Message-ID: 20130605124404.12849.80548 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110433/
-----------------------------------------------------------
(Updated June 5, 2013, 12:44 p.m.)
Status
------
This change has been marked as submitted.
Review request for Bluedevil and Àlex Fiestas.
Description
-------
In bluedevil-wizard's initial screen, the current code listens on the itemActivated \
signal of the device list. When it is emitted, the slot (itemSelected) sets some \
internal state referring to the currently selected device and, under the right \
conditions, enables the Next button. Depending on the configuration, itemActivated is \
triggered either by a single-click or a double-click.
I have a double-click configuration, therefore I have to double-click-on-the-device + \
press-Next in order to select a device. This feels very unnatural to me. Furthermore, \
if I only click once on the device, the Next button does not get enabled at all \
(because itemActivated is not emitted).
This patch makes it possible to just single-click-on-the-device + press-Next.
As I said on IRC, this patch is basically a revert of afiestas' commit \
de479d87cd07103f1f4e85b988f7197b4a329535, therefore I would very much appreciate his \
review on this patch.
Diffs
-----
src/wizard/pages/discoverpage.cpp e9ba3ab
Diff: http://git.reviewboard.kde.org/r/110433/diff/
Testing
-------
Tested UI interaction both with the mouse and the keyboard.
Thanks,
Fabio D'Urso
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/110433/">http://git.reviewboard.kde.org/r/110433/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray \
solid;"> <tr>
<td>
<h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been \
marked as submitted.</h1> </td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Bluedevil and Àlex Fiestas.</div>
<div>By Fabio D'Urso.</div>
<p style="color: grey;"><i>Updated June 5, 2013, 12:44 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">In bluedevil-wizard's initial screen, the current code listens on \
the itemActivated signal of the device list. When it is emitted, the slot \
(itemSelected) sets some internal state referring to the currently selected device \
and, under the right conditions, enables the Next button. Depending on the \
configuration, itemActivated is triggered either by a single-click or a double-click.
I have a double-click configuration, therefore I have to double-click-on-the-device + \
press-Next in order to select a device. This feels very unnatural to me. Furthermore, \
if I only click once on the device, the Next button does not get enabled at all \
(because itemActivated is not emitted).
This patch makes it possible to just single-click-on-the-device + press-Next.
As I said on IRC, this patch is basically a revert of afiestas' commit \
de479d87cd07103f1f4e85b988f7197b4a329535, therefore I would very much appreciate his \
review on this patch.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tested UI interaction both with the mouse and the keyboard.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/wizard/pages/discoverpage.cpp <span style="color: \
grey">(e9ba3ab)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/110433/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Kde-hardware-devel mailing list
Kde-hardware-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-hardware-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic