[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-hardware-devel
Subject: Re: [Kde-hardware-devel] Review Request 110384: Add isPowerSupply support to PowerDevil
From: "Dario Freddi" <drf () kde ! org>
Date: 2013-05-13 14:31:27
Message-ID: 20130513143127.30949.77540 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110384/#review32449
-----------------------------------------------------------
Ship it!
Ship It!
- Dario Freddi
On May 13, 2013, 10:57 a.m., Kai Uwe Broulik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110384/
> -----------------------------------------------------------
>
> (Updated May 13, 2013, 10:57 a.m.)
>
>
> Review request for Solid.
>
>
> Description
> -------
>
> This patch adds support for the "power supply" property in UPower batteries that \
> tells if a battery is actually powering the machine (ie. laptop battery) or just \
> inside a peripheral device (ie. mouse, keyboard, ..)
> In the UDev backend it reads the power supply property, in HAL, which doesn't \
> support this, we're assuming that primary battery and UPS battery are power supply \
> and others are not (which is the current way PowerDevil for example determins \
> whether a computer has a battery or not). Can be somewhat problematic as not all \
> mice report themselves as mouse battery.
> This patch will in the end allow for example Plasma's battery monitor to only \
> average battery percentage of batteries that are actually powering the machine, or \
> PowerDevil to emit a separate message when your mouse battery goes low.
>
> Diffs
> -----
>
> solid/solid/backends/fakehw/fakebattery.h c7e2791
> solid/solid/backends/fakehw/fakebattery.cpp 0afe765
> solid/solid/backends/fakehw/fakecomputer.xml fe7e323
> solid/solid/backends/hal/halbattery.h e2f38a0
> solid/solid/backends/hal/halbattery.cpp 4c530da
> solid/solid/backends/upower/upowerbattery.h 9d52f7b
> solid/solid/backends/upower/upowerbattery.cpp 1a40a2a
> solid/solid/backends/upower/upowerdevice.cpp 4930053
> solid/solid/battery.h 3afac6f
> solid/solid/battery.cpp 37d7321
> solid/solid/ifaces/battery.h 9987d18
>
> Diff: http://git.reviewboard.kde.org/r/110384/diff/
>
>
> Testing
> -------
>
> After adjusting Plasma's powermanagement dataengine and battery monitor, I had it \
> show two batteries (laptop battery and bluetooth mouse) and only take the laptop \
> battery for battery percentage.
>
> Thanks,
>
> Kai Uwe Broulik
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/110384/">http://git.reviewboard.kde.org/r/110384/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre> <br />
<p>- Dario</p>
<br />
<p>On May 13th, 2013, 10:57 a.m. UTC, Kai Uwe Broulik wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Solid.</div>
<div>By Kai Uwe Broulik.</div>
<p style="color: grey;"><i>Updated May 13, 2013, 10:57 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch adds support for the "power supply" property in \
UPower batteries that tells if a battery is actually powering the machine (ie. laptop \
battery) or just inside a peripheral device (ie. mouse, keyboard, ..)
In the UDev backend it reads the power supply property, in HAL, which doesn't \
support this, we're assuming that primary battery and UPS battery are power \
supply and others are not (which is the current way PowerDevil for example determins \
whether a computer has a battery or not). Can be somewhat problematic as not all mice \
report themselves as mouse battery.
This patch will in the end allow for example Plasma's battery monitor to only \
average battery percentage of batteries that are actually powering the machine, or \
PowerDevil to emit a separate message when your mouse battery goes low.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">After adjusting Plasma's powermanagement dataengine and battery \
monitor, I had it show two batteries (laptop battery and bluetooth mouse) and only \
take the laptop battery for battery percentage.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>solid/solid/backends/fakehw/fakebattery.h <span style="color: \
grey">(c7e2791)</span></li>
<li>solid/solid/backends/fakehw/fakebattery.cpp <span style="color: \
grey">(0afe765)</span></li>
<li>solid/solid/backends/fakehw/fakecomputer.xml <span style="color: \
grey">(fe7e323)</span></li>
<li>solid/solid/backends/hal/halbattery.h <span style="color: \
grey">(e2f38a0)</span></li>
<li>solid/solid/backends/hal/halbattery.cpp <span style="color: \
grey">(4c530da)</span></li>
<li>solid/solid/backends/upower/upowerbattery.h <span style="color: \
grey">(9d52f7b)</span></li>
<li>solid/solid/backends/upower/upowerbattery.cpp <span style="color: \
grey">(1a40a2a)</span></li>
<li>solid/solid/backends/upower/upowerdevice.cpp <span style="color: \
grey">(4930053)</span></li>
<li>solid/solid/battery.h <span style="color: grey">(3afac6f)</span></li>
<li>solid/solid/battery.cpp <span style="color: grey">(37d7321)</span></li>
<li>solid/solid/ifaces/battery.h <span style="color: grey">(9987d18)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/110384/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Kde-hardware-devel mailing list
Kde-hardware-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-hardware-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic