[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-hardware-devel
Subject: Re: [Kde-hardware-devel] Review Request 108407: systemd-login1 support for PowerDevil
From: "Dario Freddi" <drf () kde ! org>
Date: 2013-01-17 14:04:09
Message-ID: 20130117140409.6879.3925 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On Jan. 17, 2013, 1:03 a.m., Dario Freddi wrote:
> > After a second look, there's a whole load of synchronous things in the backend \
> > init, hence I'd waive the .waitForFinished() version to be merged, with a huge \
> > note to self to revise that whole init routine for 4.11 (already on it). Thanks \
> > for such an amazing job and your patience.
> > P.S.: Just to be fully clear, please merge the last rev without the \
> > QDBusPendingCallWatcher, as that other patch wouldn't work.
>
> Lukáš Tinkl wrote:
> I'm considering waiting with the merge after KDE 4.10 gets released, we have to \
> test it in F18 a bit more and find out ways to fix the "resuming" signal
> Lukáš Tinkl wrote:
> Oh and a bug in kernel breaks hibernation as well :) \
> https://bugzilla.redhat.com/show_bug.cgi?id=896243
Wonderful :) This makes my "ship it" void I guess :P
- Dario
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108407/#review25705
-----------------------------------------------------------
On Jan. 14, 2013, 2:24 p.m., Lukáš Tinkl wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108407/
> -----------------------------------------------------------
>
> (Updated Jan. 14, 2013, 2:24 p.m.)
>
>
> Review request for Solid and Dario Freddi.
>
>
> Description
> -------
>
> This patch adds support for systemd-login1 service to Powerdevil's upower backend. \
> The main purpose is that UPower will be soon dropping support[1] for suspend/resume \
> features so we have to rely on systemd. With this login1, we are also gaining \
> support for HybridSleep, where implemented by the system.
> One caveat: the current login1 implementation doesn't support[2] emitting the \
> "resume from suspend" signal
> [1] http://lists.freedesktop.org/archives/devkit-devel/2013-January/001339.html
> [2] http://www.freedesktop.org/wiki/Software/systemd/inhibit
>
>
> This addresses bug https://bugzilla.redhat.com/show_bug.cgi?id=859227.
> http://bugs.kde.org/show_bug.cgi?id=https://bugzilla.redhat.com/show_bug.cgi?id=859227
>
>
> Diffs
> -----
>
> powerdevil/daemon/BackendConfig.cmake 5dbe6f6
> powerdevil/daemon/backends/upower/login1suspendjob.h PRE-CREATION
> powerdevil/daemon/backends/upower/login1suspendjob.cpp PRE-CREATION
> powerdevil/daemon/backends/upower/powerdevilupowerbackend.h ba942bd
> powerdevil/daemon/backends/upower/powerdevilupowerbackend.cpp 97a409b
> powerdevil/daemon/backends/upower/upowersuspendjob.h bbe2f45
> powerdevil/daemon/backends/upower/upowersuspendjob.cpp fa64ab0
>
> Diff: http://git.reviewboard.kde.org/r/108407/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Lukáš Tinkl
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/108407/">http://git.reviewboard.kde.org/r/108407/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On January 17th, 2013, 1:03 a.m. UTC, <b>Dario \
Freddi</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">After a second look, there's a whole load of synchronous things in \
the backend init, hence I'd waive the .waitForFinished() version to be merged, \
with a huge note to self to revise that whole init routine for 4.11 (already on it). \
Thanks for such an amazing job and your patience.
P.S.: Just to be fully clear, please merge the last rev without the \
QDBusPendingCallWatcher, as that other patch wouldn't work.</pre> </blockquote>
<p>On January 17th, 2013, 12:02 p.m. UTC, <b>Lukáš Tinkl</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I'm considering \
waiting with the merge after KDE 4.10 gets released, we have to test it in F18 a bit \
more and find out ways to fix the "resuming" signal</pre> </blockquote>
<p>On January 17th, 2013, 12:04 p.m. UTC, <b>Lukáš Tinkl</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Oh and a bug in kernel \
breaks hibernation as well :) \
https://bugzilla.redhat.com/show_bug.cgi?id=896243</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Wonderful :) This makes \
my "ship it" void I guess :P</pre> <br />
<p>- Dario</p>
<br />
<p>On January 14th, 2013, 2:24 p.m. UTC, Lukáš Tinkl wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Solid and Dario Freddi.</div>
<div>By Lukáš Tinkl.</div>
<p style="color: grey;"><i>Updated Jan. 14, 2013, 2:24 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch adds support for systemd-login1 service to Powerdevil's \
upower backend. The main purpose is that UPower will be soon dropping support[1] for \
suspend/resume features so we have to rely on systemd. With this login1, we are also \
gaining support for HybridSleep, where implemented by the system.
One caveat: the current login1 implementation doesn't support[2] emitting the \
"resume from suspend" signal
[1] http://lists.freedesktop.org/archives/devkit-devel/2013-January/001339.html
[2] http://www.freedesktop.org/wiki/Software/systemd/inhibit</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=https://bugzilla.redhat.com/show_bug.cgi?id=859227">https://bugzilla.redhat.com/show_bug.cgi?id=859227</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>powerdevil/daemon/BackendConfig.cmake <span style="color: \
grey">(5dbe6f6)</span></li>
<li>powerdevil/daemon/backends/upower/login1suspendjob.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>powerdevil/daemon/backends/upower/login1suspendjob.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>powerdevil/daemon/backends/upower/powerdevilupowerbackend.h <span style="color: \
grey">(ba942bd)</span></li>
<li>powerdevil/daemon/backends/upower/powerdevilupowerbackend.cpp <span \
style="color: grey">(97a409b)</span></li>
<li>powerdevil/daemon/backends/upower/upowersuspendjob.h <span style="color: \
grey">(bbe2f45)</span></li>
<li>powerdevil/daemon/backends/upower/upowersuspendjob.cpp <span style="color: \
grey">(fa64ab0)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/108407/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Kde-hardware-devel mailing list
Kde-hardware-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-hardware-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic