'Re: [Kde-hardware-devel] Review Request 108394: add primaryOutput method to KScreen::Config class'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-hardware-devel
Subject:    Re: [Kde-hardware-devel] Review Request 108394: add primaryOutput method to KScreen::Config class
From:       Dan_Vrátil <dvratil () redhat ! com>
Date:       2013-01-14 9:23:05
Message-ID: 20130114092305.21922.34848 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108394/#review25431
-----------------------------------------------------------

Ship it!

Ship It!

- Dan Vrátil

On Jan. 14, 2013, 1:29 a.m., Jeremy Paul Whiting wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108394/
> -----------------------------------------------------------
> 
> (Updated Jan. 14, 2013, 1:29 a.m.)
> 
> 
> Review request for Solid and Àlex Fiestas.
> 
> 
> Description
> -------
> 
> This just adds a simple helper method to easily get the primary output.
> 
> 
> Diffs
> -----
> 
>   src/config.h 470bef848fe8a25debd7a900646a96481c608bcc 
>   src/config.cpp d98f123d69e8f5ed4211ec789937ee5a1bf3e4ea 
> 
> Diff: http://git.reviewboard.kde.org/r/108394/diff/
> 
> 
> Testing
> -------
> 
> It works fine here in my orientation dataengine code.
> 
> 
> Thanks,
> 
> Jeremy Paul Whiting
> 
>

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/108394/">http://git.reviewboard.kde.org/r/108394/</a>
  </td>
    </tr>
   </table>
   <br />

 <p>Ship it!</p>

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre>  <br />

<p>- Dan</p>

<br />
<p>On January 14th, 2013, 1:29 a.m. CET, Jeremy Paul Whiting wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Solid and Àlex Fiestas.</div>
<div>By Jeremy Paul Whiting.</div>

<p style="color: grey;"><i>Updated Jan. 14, 2013, 1:29 a.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This just adds a simple helper method to easily get the primary \
output.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">It works fine here in my orientation dataengine code.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/config.h <span style="color: \
grey">(470bef848fe8a25debd7a900646a96481c608bcc)</span></li>

 <li>src/config.cpp <span style="color: \
grey">(d98f123d69e8f5ed4211ec789937ee5a1bf3e4ea)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/108394/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Kde-hardware-devel mailing list
Kde-hardware-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-hardware-devel

[prev in list] [next in list] [prev in thread] [next in thread] 