[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-hardware-devel
Subject: [Kde-hardware-devel] Review Request: Make Keyboard Backlight Control Keys Work
From: "Andreas Lauser" <and () poware ! org>
Date: 2013-01-06 20:45:25
Message-ID: 20130106204525.12552.46461 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108232/
-----------------------------------------------------------
Review request for Solid.
Description
-------
This partially fixes bug #288179. Partially, because currently there
is no GUI yet for setting the keyboard backlight, and the OSD does not
show the correct icon when using the special keys for keyboard
backlight control.
For the OSD issue (it shows a monitor instead of a keyboard icon), I
could not figure out how to update the relevant code. AFAICS the problem is
that powerdevil only emits the brightnessChanged(float) signal, but
does not seem to implement the OSD itself; further, the
brightnessChanged(float) signal seems to be a part of Solid but I did
not want to change the solid API, as IMHO this might potentially break too many
things.
This addresses bug 288179.
http://bugs.kde.org/show_bug.cgi?id=288179
Diffs
-----
powerdevil/daemon/backends/hal/powerdevilhalbackend.h be00217
powerdevil/daemon/backends/hal/powerdevilhalbackend.cpp 23878c3
powerdevil/daemon/backends/upower/powerdevilupowerbackend.h ba942bd
powerdevil/daemon/backends/upower/powerdevilupowerbackend.cpp 97a409b
powerdevil/daemon/powerdevilbackendinterface.h 91519a9
powerdevil/daemon/powerdevilcore.h 77c3f2f
powerdevil/daemon/powerdevilcore.cpp 2dcdbc6
Diff: http://git.reviewboard.kde.org/r/108232/diff/
Testing
-------
I've currently only tested this patch on my samsung 900x3a laptop, so
your milage may vary. On this laptop with Kubuntu 12.10 the special keys worked with \
this patch, but I had to first instruct udev to recognize the special keys using
sudo /lib/udev/keymap "/dev/input/event4" /lib/udev/keymaps/samsung-900x3a
Thanks,
Andreas Lauser
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/108232/">http://git.reviewboard.kde.org/r/108232/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Solid.</div>
<div>By Andreas Lauser.</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This partially fixes bug #288179. Partially, because currently there is \
no GUI yet for setting the keyboard backlight, and the OSD does not show the correct \
icon when using the special keys for keyboard backlight control.
For the OSD issue (it shows a monitor instead of a keyboard icon), I
could not figure out how to update the relevant code. AFAICS the problem is
that powerdevil only emits the brightnessChanged(float) signal, but
does not seem to implement the OSD itself; further, the
brightnessChanged(float) signal seems to be a part of Solid but I did
not want to change the solid API, as IMHO this might potentially break too many
things.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I've currently only tested this patch on my samsung 900x3a laptop, \
so your milage may vary. On this laptop with Kubuntu 12.10 the special keys worked \
with this patch, but I had to first instruct udev to recognize the special keys using
sudo /lib/udev/keymap "/dev/input/event4" /lib/udev/keymaps/samsung-900x3a
</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=288179">288179</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>powerdevil/daemon/backends/hal/powerdevilhalbackend.h <span style="color: \
grey">(be00217)</span></li>
<li>powerdevil/daemon/backends/hal/powerdevilhalbackend.cpp <span style="color: \
grey">(23878c3)</span></li>
<li>powerdevil/daemon/backends/upower/powerdevilupowerbackend.h <span style="color: \
grey">(ba942bd)</span></li>
<li>powerdevil/daemon/backends/upower/powerdevilupowerbackend.cpp <span \
style="color: grey">(97a409b)</span></li>
<li>powerdevil/daemon/powerdevilbackendinterface.h <span style="color: \
grey">(91519a9)</span></li>
<li>powerdevil/daemon/powerdevilcore.h <span style="color: \
grey">(77c3f2f)</span></li>
<li>powerdevil/daemon/powerdevilcore.cpp <span style="color: \
grey">(2dcdbc6)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/108232/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Kde-hardware-devel mailing list
Kde-hardware-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-hardware-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic